Remove almost every single slavery reference from FGD#323
Open
pivotman319-owo wants to merge 2 commits intomasterfrom
Open
Remove almost every single slavery reference from FGD#323pivotman319-owo wants to merge 2 commits intomasterfrom
pivotman319-owo wants to merge 2 commits intomasterfrom
Conversation
Almost all references to "master"/"slave" removed from FGD except for those directly bound in engine code. Also removes MasterEnt fgd (tied to hl1 multisource) as it no longer exists in Strata engine code.
TeamSpen210
requested changes
Apr 21, 2026
| spawnflags(flags) : "spawnflags" = | ||
| [ | ||
| 1: "Master (Has priority if multiple env_fog_controllers exist)" : 0 | ||
| 1: "Primary Fog Controller" : 0 |
Member
There was a problem hiding this comment.
Might be good to still keep these explanatory bits in parentheses.
Member
Author
There was a problem hiding this comment.
I wanted to do this, but apparently the FGD compiler chokes on having such syntax, even after we added support for parsing spawnflag descriptions in Hammer
Member
There was a problem hiding this comment.
Well just in the flag name, as it is already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes virtually almost all references to the "master"/"slave" terminology from the Strata FGDs, except for internal keyvalues parameters directly bound to by engine code.
The
MasterEntFGD (which was used by the HL1multisourceentity) has also been removed as it no longer exists in Strata engine code. Any entity that used to rely on this has had their FGDs modified to no longer reference it.