chore: env allowlist + .cache exclude + CLAUDE.md fleet rules#624
Merged
John-David Dalton (jdalton) merged 3 commits intomainfrom Apr 27, 2026
Merged
chore: env allowlist + .cache exclude + CLAUDE.md fleet rules#624John-David Dalton (jdalton) merged 3 commits intomainfrom
John-David Dalton (jdalton) merged 3 commits intomainfrom
Conversation
Doc/config-only updates split out from PR #620. CLAUDE.md - Sync sorting + open-PR + paths + inclusive-language + Set constructor sort + don't-revert-untouched rules from the fleet - Replace whitelist/blacklist with allowlist/denylist - Document workflow-dispatch rule .config/tsconfig.check.json - Restore .cache/** exclude (was previously dropped) .gitignore - Add **/.cache/ .claude/agents/security-reviewer.md .claude/skills/security-scan/SKILL.md - Sync from socket-repo-template canonical No runtime behavior changes.
Contributor
Author
|
bugbot run |
Bill Li (billxinli)
approved these changes
Apr 27, 2026
Replaces blanket Bash/Grep/Glob entries with command-pattern-specific matchers (Bash(prefix:*)) so the skill cannot run anything the body of the skill doesn't actually invoke. Drops Grep/Glob from skills that don't use them. - security-scan: Task, Read, Bash(pnpm exec agentshield:*), Bash(zizmor:*), Bash(command -v:*), Bash(find .cache/external-tools/zizmor:*) - updating: Read, Edit, Bash(pnpm run:*), Bash(pnpm test:*), Bash(git status:*), Bash(git diff:*), Bash(git add:*), Bash(git commit:*), Bash(git log:*) Addresses billxinli's review on PR #624 / #1283.
…s, allowed-tools to quality-scan
Extends the .claude/ tightening already on this branch:
- Adds tools: frontmatter to all three agents so they declare exactly
what they need instead of inheriting the default tool set:
- code-reviewer (read-only): Read, Grep, Glob, Bash(git/rg/grep/find/ls/wc/cat/head/tail:*)
- security-reviewer: same + Bash(pnpm exec agentshield:*), Bash(zizmor:*),
Bash(command -v:*)
- refactor-cleaner: adds Edit, Write, Bash(pnpm run/test/exec:*), Bash(node:*)
- Adds permissions.deny block to .claude/settings.json blocking
publish/release escape hatches: npm/pnpm/yarn publish, gh release
create/delete, gh workflow run/dispatch, git push --force/-f.
Particularly important for socket-sdk-js, which publishes to npm
but currently has no Bash-targeted PreToolUse hooks.
- Adds allowed-tools: to quality-scan/SKILL.md (was missing entirely,
inheriting full default access).
Mirrors the canonical pattern landed on socket-repo-template main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc/config-only split from #620. Self-landable; no runtime impact.
Files
CLAUDE.md— sync fleet rules (sorting, open-PR, paths, inclusive-language, Set constructor sort, don't-revert-untouched, workflow-dispatch); replace whitelist/blacklist with allowlist/denylist.config/tsconfig.check.json— restore.cache/**exclude.gitignore— add**/.cache/.claude/agents/security-reviewer.md— sync from socket-repo-template canonical.claude/skills/security-scan/SKILL.md— sync from socket-repo-template canonicalTest plan