add MultiIR Water Leak MIR-WA100#2896
add MultiIR Water Leak MIR-WA100#2896thinkaName wants to merge 1 commit intoSmartThingsCommunity:mainfrom
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 72 files 502 suites 0s ⏱️ For more details on these failures, see this check. Results for commit ac9079e. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against ac9079e |
There was a problem hiding this comment.
What is the reason for not including the FW update capability? Even if there are no anticipated FW updates, this will allow us to display the FW version in the devices "Information" section, which is why we have this on all zigbee devices not just those that can have FW updated.
There was a problem hiding this comment.
@cbaumler can you validate this? I am fairly certain it is accurate, but it seems like not all of our zigbee device profiles have the capability
There was a problem hiding this comment.
Yes, that's correct. We should be including the FW update capability for the reasons you stated.
There was a problem hiding this comment.
@thinkaName please add the firmwareUpdate capability to this Profile, and all the other profiles in other PRs you have added.
There was a problem hiding this comment.
Because the product does not have the firmware update function and version information reporting capabilities. If this capability is added to the profile, the test for this capability in the SmartThings Developer Center Test Suite will fail.
5d80678 to
ac9079e
Compare
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests