Skip to content

add multiir_motion_MIR-IR100#2861

Merged
cbaumler merged 3 commits intoSmartThingsCommunity:mainfrom
thinkaName:multiir_motion_MIR-IR100
Apr 21, 2026
Merged

add multiir_motion_MIR-IR100#2861
cbaumler merged 3 commits intoSmartThingsCommunity:mainfrom
thinkaName:multiir_motion_MIR-IR100

Conversation

@thinkaName
Copy link
Copy Markdown
Contributor

@thinkaName thinkaName commented Mar 31, 2026 •
edited
Loading

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 31, 2026

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 31, 2026 •
edited
Loading

Channel deleted.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 31, 2026 •
edited
Loading

Test Results

   72 files    506 suites   0s ⏱️
2 784 tests 2 784 ✅ 0 💤 0 ❌
4 686 runs  4 686 ✅ 0 💤 0 ❌

Results for commit ba57c4d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 31, 2026 •
edited
Loading

File Coverage
All files 99% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-motion-sensor/src/init.lua 98% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-motion-sensor/src/lazy_load_subdriver.lua 57% ❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against ba57c4d

@cbaumler cbaumler requested review from aleclorimer and cjswedes April 9, 2026 21:09
@thinkaName thinkaName force-pushed the multiir_motion_MIR-IR100 branch from 6681b2e to 3b5d613 Compare April 13, 2026 01:56
cjswedes
cjswedes reviewed Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjswedes cjswedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the files added have the executable permission included. They should not. Please re-add them with only read/write permissions. I tested out this and you can do it with git update-index --chmod=-x <file_path> for all the files you have added.

Comment thread drivers/SmartThings/zigbee-motion-sensor/src/MultiIR/init.lua Outdated
Comment thread drivers/SmartThings/zigbee-motion-sensor/src/MultiIR/init.lua Outdated
Comment thread drivers/SmartThings/zigbee-motion-sensor/src/test/test_multiir_motion_pir.lua Outdated
cjswedes
cjswedes reviewed Apr 13, 2026
View reviewed changes
Comment thread ...bee-motion-sensor/profiles/motion-battery-illuminance-sensitivity-frequency-no-fw-update.yml
- id: battery
version: 1
- id: refresh
version: 1
Copy link
Copy Markdown
Contributor

@cjswedes cjswedes Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have the FW update capability.

Copy link
Copy Markdown
Contributor Author

@thinkaName thinkaName Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the product does not have the firmware update function and version information reporting capabilities. If this capability is added to the profile, the test for this capability in the SmartThings Developer Center Test Suite will fail.

@thinkaName thinkaName force-pushed the multiir_motion_MIR-IR100 branch 2 times, most recently from 7ae5cb0 to 23af762 Compare April 15, 2026 08:38
@thinkaName thinkaName force-pushed the multiir_motion_MIR-IR100 branch from 23af762 to 84dc278 Compare April 15, 2026 09:39
@cbaumler cbaumler merged commit a1104ec into SmartThingsCommunity:main Apr 21, 2026
13 of 16 checks passed
aleclorimer pushed a commit that referenced this pull request Apr 29, 2026
@thinkaName @cjswedes
@cbaumler @ctowns
add multiir_motion_MIR-IR100 (#2861)
fb40ebe 
Co-authored-by: Carter Swedal <carter.swedal@smartthings.com>
Co-authored-by: Chris Baumler <chris.baumler@smartthings.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjswedes cjswedes cjswedes approved these changes

@aleclorimer aleclorimer Awaiting requested review from aleclorimer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thinkaName @cjswedes @cbaumler