Benchmark and send telemetry events for indexing and resolution#4074
Merged
vinistock merged 1 commit intorubydex_adoption_feature_branchfrom Apr 23, 2026
Merged
Conversation
vinistock
added
server
rafaelfranca
approved these changes
Apr 23, 2026
vinistock
added a commit
that referenced
this pull request
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
An important part after adopting Rubydex will be tracking performance of indexing and resolution (both full and incremental). This PR adds a benchmark telemetry event for all of these, so that we can easily spot performance regressions.
Implementation
The idea is to add a helper that benchmarks and automatically creates the telemetry event for us. I reused the
ruby_lsp.response_timemetric to avoid having to create a new one.Automated Tests
Just a couple of corrections since we now push a new message to the outgoing queue.