Skip to content

Complete keyword hover with Rubydex#4073

Merged
vinistock merged 1 commit intorubydex_adoption_feature_branchfrom
vs_complete_keyword_hover
Apr 30, 2026
Merged

Complete keyword hover with Rubydex#4073
vinistock merged 1 commit intorubydex_adoption_feature_branchfrom
vs_complete_keyword_hover

Conversation

@vinistock
Copy link
Copy Markdown
Member

Motivation

Closes #2227

Originally, I was thinking we would have long form articles describing each one of the Ruby keywords. After some time reflecting, I think that's overkill and it's actually delaying us from delivering a simpler yet useful implementation.

This PR removes the entire concept of static docs and instead relies on Rubydex to show completion for all keywords.

Implementation

  1. Removed everything related to static docs
  2. Removed the ALLOWED_TARGETS thing, which was actually completely unnecessary and causing extra complexity
  3. Started handling more nodes that involve keywords
  4. Started passing the position to the hover listener, so that it can check if the user is hovering exactly over the specific keyword. This is necessary because keywords are not always nodes themselves, but only part of another node
  5. Migrated completion resolve to use Rubydex for keywords only (the rest will come with completion)

Automated Tests

Added a bunch of tests verifying how hover should behave for keywords.

@vinistock vinistock requested review from alexcrocha and st0012 April 22, 2026 17:47
@vinistock vinistock self-assigned this Apr 22, 2026
@vinistock vinistock requested a review from a team as a code owner April 22, 2026 17:47
@vinistock vinistock added enhancement New feature or request server This pull request should be included in the server gem's release notes labels Apr 22, 2026
@vinistock vinistock force-pushed the rubydex_adoption_feature_branch branch from 328b3db to d1435ac Compare April 28, 2026 14:34
@vinistock vinistock force-pushed the vs_complete_keyword_hover branch from 5a15b86 to 9af3aa6 Compare April 28, 2026 14:35
@vinistock vinistock merged commit 9f6b0e0 into rubydex_adoption_feature_branch Apr 30, 2026
37 checks passed
@vinistock vinistock deleted the vs_complete_keyword_hover branch April 30, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request server This pull request should be included in the server gem's release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants