Skip to content

Migrate find references to Rubydex#4066

Open
vinistock wants to merge 1 commit intovs_fix_node_context_for_methods_with_receiversfrom
vs_migrate_find_references_to_rubydex
Open

Migrate find references to Rubydex#4066
vinistock wants to merge 1 commit intovs_fix_node_context_for_methods_with_receiversfrom
vs_migrate_find_references_to_rubydex

Conversation

@vinistock
Copy link
Copy Markdown
Member

Motivation

Migrate find references to use Rubydex. There are two things missing, which I encoded in the tests:

  1. Indexing instance variable references (I have a branch going)
  2. Exposing method reference receivers, so that we can be more precise about references

Implementation

I migrated the request in a way that it's already prepared to account for instance, class and global variables as soon as we add support for it in Rubydex.

Automated Tests

Added a bunch of new tests trying to encode all sorts of behaviours that the previous ones didn't. For example:

  • Ensuring that the request only shows references if you have the cursor exactly on top of names
  • The placeholder behaviour for global, class and instance variables
  • Different variations of method references

@vinistock vinistock self-assigned this Apr 17, 2026
@vinistock vinistock requested a review from a team as a code owner April 17, 2026 13:46
@vinistock vinistock added server This pull request should be included in the server gem's release notes other Changes that aren't bugfixes, enhancements or breaking changes labels Apr 17, 2026
@vinistock vinistock requested review from alexcrocha and st0012 April 17, 2026 13:46
@vinistock vinistock mentioned this pull request Apr 20, 2026
19 tasks
@vinistock vinistock force-pushed the vs_fix_node_context_for_methods_with_receivers branch from 338eeee to 4c1f108 Compare April 21, 2026 15:02
@vinistock vinistock force-pushed the vs_migrate_find_references_to_rubydex branch from 3586cfd to d336389 Compare April 21, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

other Changes that aren't bugfixes, enhancements or breaking changes server This pull request should be included in the server gem's release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant