Migrate find references to Rubydex#4066
Open
vinistock wants to merge 1 commit intovs_fix_node_context_for_methods_with_receiversfrom
Open
Migrate find references to Rubydex#4066vinistock wants to merge 1 commit intovs_fix_node_context_for_methods_with_receiversfrom
vinistock wants to merge 1 commit intovs_fix_node_context_for_methods_with_receiversfrom
Conversation
19 tasks
338eeee to
4c1f108
Compare
3586cfd to
d336389
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Migrate find references to use Rubydex. There are two things missing, which I encoded in the tests:
Implementation
I migrated the request in a way that it's already prepared to account for instance, class and global variables as soon as we add support for it in Rubydex.
Automated Tests
Added a bunch of new tests trying to encode all sorts of behaviours that the previous ones didn't. For example: