Skip to content

Send store to analytics on store commands#7325

Merged
gonzaloriestra merged 1 commit intomainfrom
log-store-in-store-commands
Apr 17, 2026
Merged

Send store to analytics on store commands#7325
gonzaloriestra merged 1 commit intomainfrom
log-store-in-store-commands

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

@gonzaloriestra gonzaloriestra commented Apr 16, 2026

WHY are these changes introduced?

Store commands are not sending analytics about the selected store

See https://shopify.slack.com/archives/C0ASQECGH2Q/p1776287082626409?thread_ts=1776203153.988669&cid=C0ASQECGH2Q

WHAT is this pull request doing?

Adds the store as sensitive metadata for Monorail on store commands

How to test your changes?

  • pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260416101554
  • shopify store auth --verbose
  • shopify store execute --verbose

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing, so I've added a changelog entry with pnpm changeset add

@gonzaloriestra
Copy link
Copy Markdown
Contributor Author

/snapit

@github-actions
Copy link
Copy Markdown
Contributor

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

 i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260416091051

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@gonzaloriestra
Copy link
Copy Markdown
Contributor Author

/snapit

@github-actions
Copy link
Copy Markdown
Contributor

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

 i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260416094436

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@gonzaloriestra
Copy link
Copy Markdown
Contributor Author

/snapit

@github-actions
Copy link
Copy Markdown
Contributor

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260416101554

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@gonzaloriestra gonzaloriestra marked this pull request as ready for review April 16, 2026 10:54
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner April 16, 2026 10:54
Comment thread packages/cli/src/cli/commands/store/auth.ts Outdated
@gonzaloriestra gonzaloriestra force-pushed the log-store-in-store-commands branch 2 times, most recently from 6fa1542 to c58faa1 Compare April 16, 2026 11:58
@gonzaloriestra gonzaloriestra force-pushed the log-store-in-store-commands branch from c58faa1 to 8b751ab Compare April 16, 2026 14:07
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner April 16, 2026 14:07
@gonzaloriestra gonzaloriestra added this pull request to the merge queue Apr 17, 2026
Merged via the queue into main with commit ee4d4b5 Apr 17, 2026
25 checks passed
@gonzaloriestra gonzaloriestra deleted the log-store-in-store-commands branch April 17, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants