Conversation
Member
|
There is #113 which improves the whole generation process. I sadly haven't had the time to review it, but you might :) |
BennoLossin
previously approved these changes
Apr 14, 2026
Member
BennoLossin
left a comment
BennoLossin
left a comment
There was a problem hiding this comment.
We can of course also have this one, but it probably is redundant.
Member
Author
|
I discovered this when reviewing #120. I want to get all small fixes out the way before reviewing a big feature :) |
The `generate_projections` function already receives a filtered field list, it does not need to filter out `#[pin]` again. Signed-off-by: Gary Guo <gary@garyguo.net>
nbdd0121
added a commit
to nbdd0121/linux
that referenced
this pull request
Apr 27, 2026
This series collects all upstream developments of pin-init to date and synchronize them to the kernel tree. A major change in this cycle is the bump of MSRV to 1.82 to get rid of unstable features, following the kernel version bump in 7.1. The MSRV is bumped straight to 1.85 as pin-init can also be used outside kernel, so we avoid bumping unless there is a need for new version. Here are the list of merged changes included in the series: - examples: mark as `#[inline]` all `From::from()`s for `Error` Rust-for-Linux/pin-init#126 - bump minimum Rust version to 1.82 Rust-for-Linux/pin-init#129 - cleanup `Zeroable` and `ZeroableOptions` Rust-for-Linux/pin-init#118 - internal: add missing where clause to projection types Rust-for-Linux/pin-init#121 - internal: internal: remove redundant `#[pin]` filtering Rust-for-Linux/pin-init#131 For information, here are the list of upstream-only changes, which are related to Cargo or tests/CI changes only. - build.rs: use `option_env!` to register env variable dependency Rust-for-Linux/pin-init#128 - clean up dependencies Rust-for-Linux/pin-init#130 - tests: add test for check correct macro hygiene Rust-for-Linux/pin-init#133 - ci: use tagged release of actions Rust-for-Linux/pin-init#134 - ci: have a single job to gate all required jobs Rust-for-Linux/pin-init#138 Best, Gary --- b4-submit-tracking --- # This section is used internally by b4 prep for tracking purposes. { "series": { "revision": 1, "change-id": "20260414-pin-init-sync-ae407945a726", "prefixes": [], "presubject": "" } }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
generate_projectionsfunction already receives a filtered field list, it does not need to filter out#[pin]again.