feat: add DeepSeek V4 Pro and Flash models with correct specs#12178
Draft
roomote-v0[bot] wants to merge 1 commit intomainfrom
Draft
feat: add DeepSeek V4 Pro and Flash models with correct specs#12178roomote-v0[bot] wants to merge 1 commit intomainfrom
roomote-v0[bot] wants to merge 1 commit intomainfrom
Conversation
…d 384K output specs
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #12174
Description
This PR attempts to address Issue #12174 per @dd00zz's feedback about correct model specs. Feedback and guidance are welcome.
Key changes:
Added
deepseek-v4-proanddeepseek-v4-flashmodels to the DeepSeek provider with correct specs:Improved thinking mode detection in the DeepSeek handler to use the
preserveReasoningflag from ModelInfo instead of hardcodingmodelId.includes("deepseek-reasoner"). This means V4 models (and any future thinking models) automatically get proper reasoning_content handling without code changes.Added comprehensive tests for both new models covering model info, thinking mode parameters, and streaming behavior.
Test Procedure
cd src && npx vitest run api/providers/__tests__/deepseek.spec.ts-- all 27 tests passturbo check-typesturbo lintPre-Submission Checklist
Documentation Updates
Additional Notes
Pricing values for V4 models are estimates and may need adjustment once official pricing is confirmed. The context window (1M) and max output (384K) specs are per @dd00zz's feedback on the issue.
Interactively review PR in Roo Code Cloud