fix(command-center): use popper positioning for layout dropdown#1975
Draft
posthog[bot] wants to merge 1 commit intomainfrom
Draft
fix(command-center): use popper positioning for layout dropdown#1975posthog[bot] wants to merge 1 commit intomainfrom
posthog[bot] wants to merge 1 commit intomainfrom
Conversation
Radix Select's default item-aligned positioning placed options above the trigger when a non-first layout was selected. The toolbar sits flush below the title bar's `-webkit-app-region: drag` zone, so any dropdown items that extended into that region were intercepted by the OS drag handler and couldn't be clicked — the first option (1x1) was effectively unselectable whenever a later option was already active. Switching to popper positioning opens the menu below the trigger, away from the drag region. Generated-By: PostHog Code Task-Id: 1ec4f740-9596-4157-b560-13f0e751ad62
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The grid-layout
Selectin the command center toolbar used Radix's default item-aligned positioning. When a non-first layout was selected (e.g.2x2), the dropdown opened with earlier options rendered above the trigger.The toolbar sits directly below the title bar, which has
-webkit-app-region: drag. The OS drag handler intercepts pointer events for anything painted over that region — even portal'd content with high z-index. So whenever the active layout wasn't1x1, the first option (1x1) overlapped the drag zone and couldn't be clicked, with hover/focus visibly off.Switching
Select.Contenttoposition="popper"makes the menu open below the trigger like a popover, away from the drag region.Test plan
2x2, then open the dropdown and click1x1— should select it3x2and3x3— every option should be hoverable and clickableCreated with PostHog Code