Skip to content

fix(sessions): preserve prompt when sending while offline #1971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
posthog wants to merge 4 commits into
base: main
Choose a base branch
from
+24 −10
Open

fix(sessions): preserve prompt when sending while offline #1971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b83d9bb
fix(sessions): preserve prompt when sending while offline
May 1, 2026
932a584
fix(sessions): drop redundant offline toast and comments
May 1, 2026
fcbabb7
fix(sessions): surface existing connectivity toast on offline submit
May 1, 2026
8a5548d
chore: untrack accidentally committed local settings file
May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions apps/code/src/renderer/features/connectivity/connectivityToast.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,21 @@ import { toast as sonnerToast } from "sonner";
const TOAST_ID = "connectivity-offline";
const OFFLINE_DEBOUNCE_MS = 5_000;

export function showOfflineToast() {
toast.error("No internet connection", {
id: TOAST_ID,
duration: Number.POSITIVE_INFINITY,
description:
"PostHog Code features that need the network are paused until you reconnect.",
});
}

// Debounces flaky transitions: only surfaces a toast when the app has been
// continuously offline for OFFLINE_DEBOUNCE_MS. The stable id guarantees the
// toast never stacks; coming back online dismisses it automatically.
export function initializeConnectivityToast() {
let pendingTimer: ReturnType<typeof setTimeout> | null = null;

const showOfflineToast = () => {
toast.error("No internet connection", {
id: TOAST_ID,
duration: Number.POSITIVE_INFINITY,
description:
"PostHog Code features that need the network are paused until you reconnect.",
});
};

const clearPending = () => {
if (pendingTimer) {
clearTimeout(pendingTimer);
Expand Down
16 changes: 15 additions & 1 deletion apps/code/src/renderer/features/sessions/components/SessionView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { isOtherOption } from "@components/action-selector/constants";
import { PermissionSelector } from "@components/permissions/PermissionSelector";
import { showOfflineToast } from "@features/connectivity/connectivityToast";
import {
PromptInput,
type EditorHandle as PromptInputHandle,
Expand All @@ -17,6 +18,7 @@ import type { Plan } from "@features/sessions/types";
import { useSettingsStore } from "@features/settings/stores/settingsStore";
import { useIsWorkspaceCloudRun } from "@features/workspace/hooks/useWorkspace";
import { useAutoFocusOnTyping } from "@hooks/useAutoFocusOnTyping";
import { useConnectivity } from "@hooks/useConnectivity";
import { Pause, Spinner, Warning } from "@phosphor-icons/react";
import { Box, Button, ContextMenu, Flex, Text } from "@radix-ui/themes";
import type { TaskRunStatus } from "@shared/types";
Expand Down Expand Up @@ -244,6 +246,18 @@ export function SessionView({
[onSendPrompt],
);

const { isOnline } = useConnectivity();
const handleBeforeSubmit = useCallback(
(text: string, clearEditor: () => void): boolean => {
if (!isOnline) {
showOfflineToast();
return false;
}
return onBeforeSubmit ? onBeforeSubmit(text, clearEditor) : true;
},
[isOnline, onBeforeSubmit],
);
Comment on lines +250 to +259
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 No user feedback when submit is blocked offline

handleBeforeSubmit silently returns false when offline, so the editor content is preserved (correct) but the user gets no indication of why their submit was ignored. The PR description and test plan explicitly state "a 'Can't send while offline' toast appears," but no such toast is fired here.

The existing connectivity toast in connectivityToast.ts is debounced by 5 s, so if the user goes offline and tries to send within that window, the submit silently no-ops with zero feedback. A toast.error(…) call is needed inside the if (!isOnline) branch.

Suggested change
const handleBeforeSubmit = useCallback(
(text: string, clearEditor: () => void): boolean => {
if (!isOnline) return false;
return onBeforeSubmit ? onBeforeSubmit(text, clearEditor) : true;
},
[isOnline, onBeforeSubmit],
);
const handleBeforeSubmit = useCallback(
(text: string, clearEditor: () => void): boolean => {
if (!isOnline) {
toast.error("Can't send while offline", {
id: "send-offline",
description: "Reconnect to the network and try again.",
});
return false;
}
return onBeforeSubmit ? onBeforeSubmit(text, clearEditor) : true;
},
[isOnline, onBeforeSubmit],
);
Prompt To Fix With AI 
This is a comment left during a code review.
Path: apps/code/src/renderer/features/sessions/components/SessionView.tsx
Line: 249-255

Comment:
**No user feedback when submit is blocked offline**

`handleBeforeSubmit` silently returns `false` when offline, so the editor content is preserved (correct) but the user gets no indication of *why* their submit was ignored. The PR description and test plan explicitly state "a 'Can't send while offline' toast appears," but no such toast is fired here.

The existing connectivity toast in `connectivityToast.ts` is debounced by 5 s, so if the user goes offline and tries to send within that window, the submit silently no-ops with zero feedback. A `toast.error(…)` call is needed inside the `if (!isOnline)` branch.

```suggestion
  const handleBeforeSubmit = useCallback(
    (text: string, clearEditor: () => void): boolean => {
      if (!isOnline) {
        toast.error("Can't send while offline", {
          id: "send-offline",
          description: "Reconnect to the network and try again.",
        });
        return false;
      }
      return onBeforeSubmit ? onBeforeSubmit(text, clearEditor) : true;
    },
    [isOnline, onBeforeSubmit],
  );
```

How can I resolve this? If you propose a fix, please make it concise.

Copy link
Copy Markdown
Contributor

@sakce sakce May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

originally, is the general toast for connectivity shown after this prompt is submitted? so if this stays as is, we would not be showing anything?

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's correct. The general connectivity toast from connectivityToast.ts fires on the isOnline state transition (after a 5-second debounce), not in response to a submit attempt. So it would show up regardless of whether the user tried to submit or not.

In the original (pre-PR) flow:

  1. onBeforeSubmit passed (no connectivity check), onSubmit fired, editor cleared
  2. sendPrompt threw asynchronously
  3. The general offline toast appeared only after the 5s debounce (unrelated to the submit)

With this PR, if the user goes offline and submits within that 5-second window, handleBeforeSubmit returns false silently — the debounced toast hasn't appeared yet and there's no submit-specific toast either, so they get zero feedback. After the 5s window the general toast is already visible, so the silent no-op is more tolerable, but it's still not great UX.

Adding a toast.error(...) in the !isOnline branch (as I originally suggested) would handle the window case and give immediate, action-specific feedback regardless of when the user goes offline.

Tip: You can customize Greptile's behavior for this repo with .greptile/rules.md and .greptile/config.json.


const [isDraggingFile, setIsDraggingFile] = useState(false);
const editorRef = useRef<PromptInputHandle>(null);
const dragCounterRef = useRef(0);
Expand Down Expand Up @@ -643,7 +657,7 @@ export function SessionView({
/>
) : null
}
onBeforeSubmit={onBeforeSubmit}
onBeforeSubmit={handleBeforeSubmit}
onSubmit={handleSubmit}
onBashCommand={onBashCommand}
onCancel={onCancelPrompt}
Expand Down
Loading