fix: add missing Popover import in DetailHeader#476
Merged
Conversation
The TagsInline component uses Popover to display hidden tags when they overflow the container width, but Popover was not imported from antd. This caused a runtime error when datasets had many tags (>5), triggering ErrorBoundary and redirecting users to homepage. Root cause: Line 3 imported Card, Button, Tag, Tooltip, Modal but missing Popover, while Popover was used at lines 193-215. Fix: Add Popover to the antd import statement.
There was a problem hiding this comment.
Pull request overview
Fixes a runtime crash in the dataset detail page when tags overflow, by ensuring the Popover component used by TagsInline is correctly imported from antd.
Changes:
- Add missing
Popoverimport tofrontend/src/components/DetailHeader.tsxto preventPopover is undefinedat runtime.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added 2 commits
April 29, 2026 12:18
The backend returns Tag objects with UUID string IDs, but frontend components
AddTagPopover and DetailHeader defined Tag interface with id: number, causing
type mismatch and potential display issues.
Changes:
- AddTagPopover.tsx: interface Tag { id: number } → { id: string }
- DetailHeader.tsx: TagConfig and TagsInline interfaces updated to id: string
This aligns with:
- Backend: TagResponse.java returns UUID string
- dataset.model.ts: TagItem interface already correctly defines id: string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a runtime crash when viewing dataset details with many tags (>5 or tags that overflow the container width).
Root Cause
The
TagsInlinecomponent inDetailHeader.tsxuses<Popover>to display hidden tags when they overflow the container width (450px). However,Popoverwas not imported from antd:Card, Button, Tag, Tooltip, Modalbut missing Popover<Popover>componentError Flow
/data/management/detail/:idhiddenCount > 0triggers Popover renderFix
Add
Popoverto the antd import statement on line 3.Test Plan