pipeline: avoid missing final indexing progress end#993
Open
SuperDuckGOGOGO wants to merge 1 commit intoMaskRay:masterfrom
Open
pipeline: avoid missing final indexing progress end#993SuperDuckGOGOGO wants to merge 1 commit intoMaskRay:masterfrom
SuperDuckGOGOGO wants to merge 1 commit intoMaskRay:masterfrom
Conversation
Wake the main loop when indexing completion advances and include progress changes in the wait predicate so the final completed==enqueued transition cannot be lost. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stats.completedadvances so the final indexing completion is not silentMultiQueueWaiterwith predicate-aware wait helpers and use them for index progress trackingcompleted == enqueuedtransition from being missed, which can otherwise suppress the final$/progress endTest plan
cclslocally with Clang CMake packages available$/progress endarrivespipeline.ccandthreaded_queue.hhcontrol flow for the lost-wakeup race