Open
Conversation
Replace flatten() with reshape(-1) to avoid copies where the data is only read. In _load_variable, use a single copy followed by in-place fill value replacement instead of flatten + np.where which created three copies.
Track which dimensions changed in SetSlicing and only reload variables whose dimensions intersect the changed set. Variables unaffected by the slice change are kept from the previous output. For example, changing lev now skips all 2D (time, ncol) variables. With 200 2D + 20 3D variables loaded, lev changes are ~2.5x faster.
Only copy and scan for fill values when the variable actually has a _FillValue attribute. Most variables default to NaN, making the comparison a no-op that still scans the entire array. Variables without fill values now return a zero-copy view from reshape.
Member
|
looks good. each of the three changes is correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made several improvements to improve read times in the reader.