fix: add tooltips and improve toolbar UI#45
Conversation
- Add tooltips to file browser buttons - Add slider/text-input toggle to DataSelection toolbar - Style hotkey badges with rounded borders - Add primary outline to active drawer toggle buttons - Fix tooltips for color config card Resolves Kitware#44
| "[track, Number($event)]", | ||
| ), | ||
| key=("track + '_' + t_idx",), | ||
| min=0, |
| v3.VIconBtn( | ||
| raw_attrs=[ | ||
| '''v-tooltip:bottom="config.color_blind ? 'Colorblind safe presets' : 'All color presets'"''' | ||
| '''v-tooltip:bottom="config.color_blind ? 'Toggle for all color presets' : 'Toggle for colorblind safe color presets'"''' |
There was a problem hiding this comment.
I think the latest vuetify that is available should now support v_tooltip_bottom="..." directly. No need to do it via a raw_attrs.
That also mean that all your nested structure could possibly be simplified with only on v_tooltip="..." directive.
| v3.VIconBtn( | ||
| raw_attrs=[ | ||
| '''v-tooltip:bottom="config.invert ? 'Inverted preset' : 'Normal preset'"''' | ||
| '''v-tooltip:bottom="config.invert ? 'Toggle to normal preset' : 'Toggle to inverted preset'"''' |
There was a problem hiding this comment.
use v_tooltip_bottom="..."?
There was a problem hiding this comment.
You may want to add a version constraint on trame-vuetify>=... in pyproject to ensure the tooltip directive works.
|
Few comments but looks great otherwise! |
…Input min/max syntax
| min=0, | ||
| max=("t_values ? t_values.length - 1 : 0",), | ||
| min=[0], | ||
| max=[("t_values ? t_values.length - 1 : 0")], |
There was a problem hiding this comment.
Since you are using [], you can remove the useless ()
There was a problem hiding this comment.
Either you do [...] or (... ,) but not [(...)]
|
All good otherwise, feel free to merge it. |
3 participants
Addresses #44