Skip to content

Handle sysmaint account password when autologin is disabled #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
assisted-by-ai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle sysmaint account password when autologin is disabled #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions usr/libexec/user-sysmaint-split/sysmaint-boot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ old_sysmaint_conf_file_list=(
'/etc/sddm.conf.d/z-sysmaint-boot.conf'
)
sudo_to_sysmaint="sudo --non-interactive -u sysmaint"
sysmaint_temp_password_flag='/run/user-sysmaint-split/temp-password-set'

bail_if_read_only() {
if test -w /etc; then
Expand All @@ -100,7 +101,39 @@ bail_if_read_only() {
exit 1
}

ensure_sysmaint_has_password() {
## When autologin is disabled, the display manager greeter requires manual
## authentication. If the sysmaint account has an empty password, PAM will
## reject login attempts because pam_unix does not allow empty passwords
## without the nullok option (which security-hardened systems remove).
## Detect this and set a temporary password so manual login works.
if [ "${sysmaint_autologin}" = "yes" ]; then
return
fi
local pass_status
pass_status="$(passwd -S sysmaint 2>/dev/null)" || true
if printf '%s\n' "${pass_status}" | grep -qw 'NP'; then
printf '%s\n' "WARNING: sysmaint account has no password and autologin is disabled." >&2
printf '%s\n' "WARNING: Setting temporary password 'changeme' for sysmaint account." >&2
printf '%s\n' "WARNING: Please change it after login using the 'passwd' command." >&2
printf '%s\n' 'sysmaint:changeme' | chpasswd
mkdir --parents -- "$(dirname -- "${sysmaint_temp_password_flag}")"
touch -- "${sysmaint_temp_password_flag}"
fi
}

restore_sysmaint_empty_password() {
## If we set a temporary password during boot, restore the empty password
## state on shutdown so the system returns to its original configuration.
if [ -f "${sysmaint_temp_password_flag}" ]; then
printf '%s\n' "INFO: Restoring empty password for sysmaint account." >&2
passwd -d sysmaint >/dev/null 2>&1 || true
safe-rm -f -- "${sysmaint_temp_password_flag}"
fi
}

restore_pre_sysmaint_autologin_config() {
restore_sysmaint_empty_password
safe-rm -f -- "${sysmaint_lightdm_conf_file}"
safe-rm -f -- "${sysmaint_sddm_conf_file}"
safe-rm -f -- "${old_sysmaint_conf_file_list[@]}"
Expand Down Expand Up @@ -354,6 +387,8 @@ handle_boot() {
rebuild_greetd_config
fi

ensure_sysmaint_has_password

## Qubes handling.
if [ ! -f /usr/share/qubes/marker-vm ]; then
return
Expand Down
9 changes: 9 additions & 0 deletions usr/libexec/user-sysmaint-split/sysmaint-boot-cleanup
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,17 @@ old_sysmaint_conf_file_list=(
'/etc/lightdm/lightdm.conf.d/60_sysmaint-boot.conf'
'/etc/sddm.conf.d/z-sysmaint-boot.conf'
)
sysmaint_temp_password_flag='/run/user-sysmaint-split/temp-password-set'
exit_code=0

## Restore empty password for sysmaint if a temporary password was set
## during boot (when autologin was disabled and the account had no password).
if [ -f "${sysmaint_temp_password_flag}" ]; then
echo "INFO: Restoring empty password for sysmaint account." >&2
passwd -d sysmaint >/dev/null 2>&1 || true
rm -f -- "${sysmaint_temp_password_flag}"
fi

echo "INFO: Removing sysmaint autologin files because system is shutting down." >&2
safe-rm -f --verbose -- "${sysmaint_lightdm_conf_file}"
safe-rm -f --verbose -- "${sysmaint_sddm_conf_file}"
Expand Down