Skip to content

Fix session guard bypass, missing stderr redirects, and uninitialized…#2

Open
assisted-by-ai wants to merge 1 commit intoKicksecure:masterfrom
assisted-by-ai:claude/fix-code-bugs-RQIks
Open

Fix session guard bypass, missing stderr redirects, and uninitialized…#2
assisted-by-ai wants to merge 1 commit intoKicksecure:masterfrom
assisted-by-ai:claude/fix-code-bugs-RQIks

Conversation

@assisted-by-ai
Copy link
Copy Markdown

… variables

  • X11_Xsession.d_15_sysmaint_no_desktop: Fix always-false session check that compared hardcoded 'sysmaint-session' against itself instead of checking $DESKTOP_SESSION, completely bypassing the safety guard
  • sysmaint-boot: Add missing >&2 redirects to printf statements in remove_sysmaint_qubes() so diagnostic messages go to stderr like all other messages in the script
  • sysmaint-session, sysmaint-session-wayland: Initialize selected_system_tray and selected_system_tray_args to empty strings before the search loop to avoid referencing uninitialized variables
  • grub.d_10_10_linux_sysmaint: Remove redundant if/elif/else where all branches assigned the same value

https://claude.ai/code/session_01QxHdBF7NnawVe5KW5cwttV

This pull request changes...

Changes

Mandatory Checklist

  • Legal agreements accepted. By contributing to this organisation, you acknowledge you have read, understood, and agree to be bound by these these agreements:

Terms of Service, Privacy Policy, Cookie Policy, E-Sign Consent, DMCA, Imprint

Optional Checklist

The following items are optional but might be requested in certain cases.

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

Fixes #

… variables

- X11_Xsession.d_15_sysmaint_no_desktop: Fix always-false session check that
  compared hardcoded 'sysmaint-session' against itself instead of checking
  $DESKTOP_SESSION, completely bypassing the safety guard
- sysmaint-boot: Add missing >&2 redirects to printf statements in
  remove_sysmaint_qubes() so diagnostic messages go to stderr like all
  other messages in the script
- sysmaint-session, sysmaint-session-wayland: Initialize selected_system_tray
  and selected_system_tray_args to empty strings before the search loop to
  avoid referencing uninitialized variables
- grub.d_10_10_linux_sysmaint: Remove redundant if/elif/else where all
  branches assigned the same value

https://claude.ai/code/session_01QxHdBF7NnawVe5KW5cwttV
@ArrayBolt3
Copy link
Copy Markdown
Contributor

Accepted almost all of the fixes as-is in ArrayBolt3@2d00f18. However, I'm using $XDG_CURRENT_DESKTOP rather than $DESKTOP_SESSION in the sysmaint GUI login check, because that's the variable that sysmaint-session-wayland sets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants