fix(Library): better handle exception and library by BotellaA · Pull Request #175 · Geode-solutions/OpenGeode-Inspector

BotellaA · 2026-04-28T06:40:32Z

No description provided.

github-actions · 2026-04-28T06:47:33Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 756 concern(s)

bindings/python/src/inspector/inspector.cpp:72:1: warning: [modernize-concat-nested-namespaces]

nested namespaces can be concatenated

   72 | namespace pybind11
      | ^~~~~~~~~~~~~~~~~~
   73 | {
      | ~
   74 |     namespace detail
      |     ~~~~~~~~~~~~~~~~
      |     namespace pybind11::detail
   75 |     {
   76 |         template < typename Key, typename Value >
   77 |         struct type_caster< absl::flat_hash_map< Key, Value > >
   78 |             : map_caster< absl::flat_hash_map< Key, Value >, Key, Value >
   79 |         {
   80 |         };
   81 | 
   82 |         template < typename Type, size_t dimension >
   83 |         struct type_caster< absl::InlinedVector< Type, dimension > >
   84 |             : list_caster< absl::InlinedVector< Type, dimension >, Type >
   85 |         {
   86 |         };
   87 |     } // namespace detail
      |     ~~~~~~~~~~~~~~~~~~~~~
      |     } // namespace pybind11::detail

src/bin/geode-inspector-brep.cpp:44:6: warning: [misc-use-internal-linkage]

function 'inspect_brep' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   44 | void inspect_brep( const geode::BRep& brep )
      |      ^
      | static 
```

src/bin/geode-inspector-brep.cpp:57:36: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

   57 |                 "Sample usage:\n", argv[0], " --input my_brep.og_brep\n",
      |                                    ^

src/bin/geode-inspector-cross-section.cpp:43:6: warning: [misc-use-internal-linkage]

function 'inspect_cross_section' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   43 | void inspect_cross_section( const geode::CrossSection& cross_section )
      |      ^
      | static 
```
src/bin/geode-inspector-cross-section.cpp:57:13: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic
```
   57 |             argv[0], " --input my_cross_section.og_xsctn\n",
      |             ^
```
src/bin/geode-inspector-edgedcurve.cpp:47:6: warning: [misc-use-internal-linkage]

function 'inspect_edged_curve' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   47 | void inspect_edged_curve( const geode::EdgedCurve< dimension >& edged_curve )
      |      ^
      | static 
```

src/bin/geode-inspector-edgedcurve.cpp:61:36: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

   61 |                 "Sample usage:\n", argv[0], " --input my_edgedcurve.og_edc3d\n",
      |                                    ^

src/bin/geode-inspector-implicit-cross-section.cpp:43:6: warning: [misc-use-internal-linkage]

function 'inspect_implicit_cross_section' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   43 | void inspect_implicit_cross_section(
      |      ^
      | static 
```

src/bin/geode-inspector-implicit-cross-section.cpp:58:32: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

   58 |             "Sample usage:\n", argv[0], " --input my_cross_section.og_ixsctn\n",
      |                                ^

src/bin/geode-inspector-implicit-structural-model.cpp:43:6: warning: [misc-use-internal-linkage]

function 'inspect_implicit_structural_model' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   43 | void inspect_implicit_structural_model(
      |      ^
      | static 
```
src/bin/geode-inspector-implicit-structural-model.cpp:57:32: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic
```
   57 |             "Sample usage:\n", argv[0],
      |                                ^
```
src/bin/geode-inspector-pointset.cpp:47:6: warning: [misc-use-internal-linkage]

function 'inspect_point_set' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   47 | void inspect_point_set( const geode::PointSet< dimension >& pointset )
      |      ^
      | static 
```
src/bin/geode-inspector-pointset.cpp:61:13: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic
```
   61 |             argv[0], " --input my_pointset.og_pts3d\n" ) );
      |             ^
```
src/bin/geode-inspector-section.cpp:43:6: warning: [misc-use-internal-linkage]

function 'inspect_section' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   43 | void inspect_section( const geode::Section& section )
      |      ^
      | static 
```

src/bin/geode-inspector-section.cpp:57:36: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

   57 |                 "Sample usage:\n", argv[0], " --input my_section.og_sctn\n",
      |                                    ^

src/bin/geode-inspector-solid.cpp:53:6: warning: [misc-use-internal-linkage]

function 'inspect_solid' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   53 | void inspect_solid( const geode::SolidMesh< dimension >& solid )
      |      ^
      | static 
```

src/bin/geode-inspector-solid.cpp:66:36: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

   66 |                 "Sample usage:\n", argv[0], " --input my_solid.og_tsf3d\n",
      |                                    ^

src/bin/geode-inspector-structural-model.cpp:43:6: warning: [misc-use-internal-linkage]

function 'inspect_model' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   43 | void inspect_model( const geode::StructuralModel& model )
      |      ^
      | static 
```
src/bin/geode-inspector-structural-model.cpp:56:36: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic
```
   56 |                 "Sample usage:\n", argv[0],
      |                                    ^
```
src/bin/geode-inspector-surface-curve-intersections.cpp:57:6: warning: [misc-use-internal-linkage]

function 'inspect_surface_curve' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   57 | void inspect_surface_curve(
      |      ^
      | static 
```
src/bin/geode-inspector-surface-curve-intersections.cpp:73:32: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic
```
   73 |             "Sample usage:\n", argv[0],
      |                                ^
```
src/bin/geode-inspector-surface.cpp:51:6: warning: [misc-use-internal-linkage]

function 'inspect_surface' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   51 | void inspect_surface( const geode::SurfaceMesh< dimension >& surface )
      |      ^
      | static 
```

src/bin/geode-inspector-surface.cpp:64:36: warning: [cppcoreguidelines-pro-bounds-pointer-arithmetic]

do not use pointer arithmetic

   64 |                 "Sample usage:\n", argv[0], " --input my_surface.og_tsf3d\n",
      |                                    ^

src/geode/inspector/criterion/internal/component_meshes_adjacency.cpp:66:1: warning: [modernize-concat-nested-namespaces]

nested namespaces can be concatenated

   66 | namespace geode
      | ^~~~~~~~~~~~~~~
   67 | {
      | ~
   68 |     namespace internal
      |     ~~~~~~~~~~~~~~~~~~
      |     namespace geode::internal

src/geode/inspector/criterion/internal/component_meshes_adjacency.cpp:79:13: warning: [readability-function-cognitive-complexity]

function 'add_surfaces_edges_with_wrong_adjacencies' has cognitive complexity of 15 (threshold 10)

   79 |             add_surfaces_edges_with_wrong_adjacencies(
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/internal/component_meshes_adjacency.cpp:83:13: note: +1, including nesting penalty of 0, nesting level increased to 1
   83 |             for( const auto& surface : model_.active_surfaces() )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/internal/component_meshes_adjacency.cpp:94:17: note: +2, including nesting penalty of 1, nesting level increased to 2
   94 |                 for( const auto polygon_id : Range{ mesh.nb_polygons() } )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/internal/component_meshes_adjacency.cpp:96:21: note: +3, including nesting penalty of 2, nesting level increased to 3
   96 |                     for( const auto edge_id :
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/internal/component_meshes_adjacency.cpp:102:29: note: +4, including nesting penalty of 3, nesting level increased to 4
  102 |                             if( mesh.is_edge_on_border( polygon_edge )
      |                             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/internal/component_meshes_adjacency.cpp:103:33: note: +1
  103 |                                 && !polygon_edge_is_on_a_line(
      |                                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/internal/component_meshes_adjacency.cpp:113:25: note: +4, including nesting penalty of 3, nesting level increased to 4
  113 |                         catch( const OpenGeodeException& e )
      |                         ^

src/geode/inspector/criterion/intersections/model_intersections.cpp:71:51: warning: [hicpp-uppercase-literal-suffix]

integer literal has suffix 'u', which is not uppercase

   71 |                 next_apex + 1 == polygon.size() ? 0u : next_apex + 1;
      |                                                   ^~
      |                                                    U

src/geode/inspector/criterion/intersections/model_intersections.cpp:101:9: warning: [modernize-use-nodiscard]

function 'polygons_intersect' should be marked [[nodiscard]]
```
  101 |         bool polygons_intersect(
      |         ^
      |         [[nodiscard]] 
```

src/geode/inspector/criterion/intersections/model_intersections.cpp:102:13: warning: [bugprone-easily-swappable-parameters]

2 adjacent parameters of 'polygons_intersect' of similar type ('geode::index_t') are easily swapped by mistake

  102 |             geode::index_t p1_id, geode::index_t p2_id ) const
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:102:28: note: the first parameter in the range is 'p1_id'
  102 |             geode::index_t p1_id, geode::index_t p2_id ) const
      |                            ^~~~~
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:102:50: note: the last parameter in the range is 'p2_id'
  102 |             geode::index_t p1_id, geode::index_t p2_id ) const
      |                                                  ^~~~~

src/geode/inspector/criterion/intersections/model_intersections.cpp:131:9: warning: [modernize-use-nodiscard]

function 'triangles_intersection_detection' should be marked [[nodiscard]]
```
  131 |         bool triangles_intersection_detection(
      |         ^
      |         [[nodiscard]] 
```
src/geode/inspector/criterion/intersections/model_intersections.cpp:142:9: warning: [modernize-use-nodiscard]

function 'triangles_common_vertices' should be marked [[nodiscard]]
```
  142 |         absl::InlinedVector< std::array< geode::index_t, 2 >, 3 >
      |         ^
      |         [[nodiscard]] 
```

src/geode/inspector/criterion/intersections/model_intersections.cpp:144:17: warning: [bugprone-easily-swappable-parameters]

2 adjacent parameters of 'triangles_common_vertices' of similar type ('const geode::PolygonVertices &') are easily swapped by mistake

  144 |                 const geode::PolygonVertices& t1_vertices,
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  145 |                 const geode::PolygonVertices& t2_vertices ) const
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:144:47: note: the first parameter in the range is 't1_vertices'
  144 |                 const geode::PolygonVertices& t1_vertices,
      |                                               ^~~~~~~~~~~
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:145:47: note: the last parameter in the range is 't2_vertices'
  145 |                 const geode::PolygonVertices& t2_vertices ) const
      |                                               ^~~~~~~~~~~

src/geode/inspector/criterion/intersections/model_intersections.cpp:167:9: warning: [modernize-use-nodiscard]

function 'triangles_intersect' should be marked [[nodiscard]]
```
  167 |         bool triangles_intersect( const geode::PolygonVertices& t1_vertices,
      |         ^
      |         [[nodiscard]] 
```
src/geode/inspector/criterion/intersections/model_intersections.cpp:178:9: warning: [modernize-use-nodiscard]

function 'mesh1' should be marked [[nodiscard]]
```
  178 |         const geode::SurfaceMesh< Model::dim >& mesh1() const
      |         ^
      |         [[nodiscard]] 
```
src/geode/inspector/criterion/intersections/model_intersections.cpp:183:9: warning: [modernize-use-nodiscard]

function 'mesh2' should be marked [[nodiscard]]
```
  183 |         const geode::SurfaceMesh< Model::dim >& mesh2() const
      |         ^
      |         [[nodiscard]] 
```
src/geode/inspector/criterion/intersections/model_intersections.cpp:188:9: warning: [modernize-use-nodiscard]

function 'mesh_triangle' should be marked [[nodiscard]]
```
  188 |         geode::Triangle< Model::dim > mesh_triangle(
      |         ^
      |         [[nodiscard]] 
```

src/geode/inspector/criterion/intersections/model_intersections.cpp:327:59: warning: [readability-function-cognitive-complexity]

function 'triangles_intersect' has cognitive complexity of 28 (threshold 10)

  327 |     bool ModelSurfacesIntersectionBase< geode::Section >::triangles_intersect(
      |                                                           ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:333:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  333 |         if( common_vertices.size() == 2 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:341:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  341 |             if( geode::segment_segment_intersection_detection(
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:345:17: note: +1
  345 |                 || geode::segment_segment_intersection_detection(
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:357:20: note: +1
  357 |                    || geode::point_triangle_position( t2_third_pt, t1 )
      |                    ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:360:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  360 |         for( const auto t1_edge_v : geode::LRange{ 3 } )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:364:44: note: +2, including nesting penalty of 1, nesting level increased to 2
  364 |                 t1_vertices[t1_edge_v == 2 ? 0 : t1_edge_v + 1]
      |                                            ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:368:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  368 |             for( const auto t2_edge_v : geode::LRange{ 3 } )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:372:48: note: +3, including nesting penalty of 2, nesting level increased to 3
  372 |                     t2_vertices[t2_edge_v == 2 ? 0 : t2_edge_v + 1]
      |                                                ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:378:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  378 |                 if( edge_edge_inter.first == geode::POSITION::outside
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:379:21: note: +1
  379 |                     || edge_edge_inter.first == geode::POSITION::parallel )
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:383:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  383 |                 if( common_vertices.size() != 1 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:391:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  391 |                 if( t1_edge_inter_pt_id == geode::NO_LID
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:392:21: note: +1
  392 |                     || t2_edge_inter_pt_id == geode::NO_LID )
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:396:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  396 |                 if( edge1_vertices[t1_edge_inter_pt_id] != common_vertices[0][0]
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:397:21: note: +1
  397 |                     || edge2_vertices[t2_edge_inter_pt_id]
      |                     ^

src/geode/inspector/criterion/intersections/model_intersections.cpp:353:24: warning: [readability-identifier-length]

variable name 't1' is too short, expected at least 3 characters
```
  353 |             const auto t1 = mesh_triangle( mesh1_, t1_vertices );
      |                        ^
```
src/geode/inspector/criterion/intersections/model_intersections.cpp:354:24: warning: [readability-identifier-length]

variable name 't2' is too short, expected at least 3 characters
```
  354 |             const auto t2 = mesh_triangle( mesh2_, t2_vertices );
      |                        ^
```

src/geode/inspector/criterion/intersections/model_intersections.cpp:407:10: warning: [readability-function-cognitive-complexity]

function 'triangle_intersects_other' has cognitive complexity of 22 (threshold 10)

  407 |     bool triangle_intersects_other( const geode::Triangle3D& t1,
      |          ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:414:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  414 |         for( const auto v_id : geode::LRange{ 3 } )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:416:42: note: +2, including nesting penalty of 1, nesting level increased to 2
  416 |             const auto v2_id = v_id == 2 ? 0 : v_id + 1;
      |                                          ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:419:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  419 |             if( intersection.first != geode::POSITION::outside )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:421:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  421 |                 if( common_vertices.size() != 1 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:429:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  429 |                 if( edge_inter_pt_id == geode::NO_LID
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:430:21: note: +1
  430 |                     || t2_inter_pt_id == geode::NO_LID )
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:434:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  434 |                 if( t1_vertices[edge_inter_pt_id == 0 ? v_id : v2_id]
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:436:21: note: +1
  436 |                     || t2_vertices[t2_inter_pt_id]
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:434:55: note: +3, including nesting penalty of 2, nesting level increased to 3
  434 |                 if( t1_vertices[edge_inter_pt_id == 0 ? v_id : v2_id]
      |                                                       ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:435:71: note: +3, including nesting penalty of 2, nesting level increased to 3
  435 |                         != common_vertices[0][t2_vertex_position == 0 ? 1 : 0]
      |                                                                       ^

src/geode/inspector/criterion/intersections/model_intersections.cpp:407:10: warning: [readability-function-size]

function 'triangle_intersects_other' exceeds recommended size/complexity thresholds

  407 |     bool triangle_intersects_other( const geode::Triangle3D& t1,
      |          ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:407:10: note: 6 parameters (threshold 4)

src/geode/inspector/criterion/intersections/model_intersections.cpp:407:62: warning: [readability-identifier-length]

parameter name 't1' is too short, expected at least 3 characters
```
  407 |     bool triangle_intersects_other( const geode::Triangle3D& t1,
      |                                                              ^
```
src/geode/inspector/criterion/intersections/model_intersections.cpp:408:34: warning: [readability-identifier-length]

parameter name 't2' is too short, expected at least 3 characters
```
  408 |         const geode::Triangle3D& t2,
      |                                  ^
```
src/geode/inspector/criterion/intersections/model_intersections.cpp:453:20: warning: [readability-identifier-length]

variable name 't2' is too short, expected at least 3 characters
```
  453 |         const auto t2 = mesh_triangle( mesh2_, t2_vertices );
      |                    ^
```
src/geode/inspector/criterion/intersections/model_intersections.cpp:470:20: warning: [readability-identifier-length]

variable name 't1' is too short, expected at least 3 characters
```
  470 |         const auto t1 = mesh_triangle( mesh1_, t1_vertices );
      |                    ^
```

src/geode/inspector/criterion/intersections/model_intersections.cpp:473:19: warning: [readability-suspicious-call-argument]

3rd argument 't2_vertices' (passed to 't1_vertices') looks like it might be swapped with the 4th, 't1_vertices' (passed to 't2_vertices')

  473 |                || triangle_intersects_other(
      |                   ^
  474 |                    t2, t1, t2_vertices, t1_vertices, common_vertices, 0 );
      |                            ~~~~~~~~~~~  ~~~~~~~~~~~
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/intersections/model_intersections.cpp:407:10: note: in the call to 'triangle_intersects_other', declared here
  407 |     bool triangle_intersects_other( const geode::Triangle3D& t1,
      |          ^
  408 |         const geode::Triangle3D& t2,
  409 |         const geode::PolygonVertices& t1_vertices,
      |                                       ~~~~~~~~~~~
  410 |         const geode::PolygonVertices& t2_vertices,
      |                                       ~~~~~~~~~~~

src/geode/inspector/criterion/intersections/model_intersections.cpp:499:9: warning: [google-explicit-constructor]

single-argument constructors must be marked explicit to avoid unintentional implicit conversions
```
  499 |         Impl( const Model& model ) : model_( model ) {}
      |         ^
      |         explicit 
```
src/geode/inspector/criterion/intersections/model_intersections.cpp:501:9: warning: [modernize-use-nodiscard]

function 'model_has_intersecting_surfaces' should be marked [[nodiscard]]
```
  501 |         bool model_has_intersecting_surfaces() const
      |         ^
      |         [[nodiscard]] 
```

src/geode/inspector/criterion/intersections/model_intersections.cpp:507:24: warning: [readability-simplify-boolean-expr]

redundant boolean literal in conditional return statement

  505 |             if( intersections.empty() )
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |             return !static_cast<bool>(intersections.empty())
  506 |             {
      |             ~
  507 |                 return false;
      |                 ~~~~~~~^~~~~~
  508 |             }
      |             ~
  509 |             return true;
      |             ~~~~~~~~~~~

src/geode/inspector/criterion/intersections/model_intersections.cpp:559:9: warning: [modernize-use-nodiscard]

function 'intersecting_polygons' should be marked [[nodiscard]]
```
  559 |         std::vector< std::pair< ComponentMeshElement, ComponentMeshElement > >
      |         ^
      |         [[nodiscard]] 
```
src/geode/inspector/criterion/intersections/model_intersections.cpp:559:9: warning: [modernize-use-nodiscard]

function 'intersecting_polygons<(anonymous namespace)::AllModelSurfacesAutoIntersectiongeode::BRep>' should be marked [[nodiscard]]
```
  559 |         std::vector< std::pair< ComponentMeshElement, ComponentMeshElement > >
      |         ^
      |         [[nodiscard]] 
```
src/geode/inspector/criterion/intersections/model_intersections.cpp:559:9: warning: [modernize-use-nodiscard]

function 'intersecting_polygons<(anonymous namespace)::AllModelSurfacesAutoIntersectiongeode::Section>' should be marked [[nodiscard]]
```
  559 |         std::vector< std::pair< ComponentMeshElement, ComponentMeshElement > >
      |         ^
      |         [[nodiscard]] 
```
src/geode/inspector/criterion/intersections/model_intersections.cpp:559:9: warning: [modernize-use-nodiscard]

function 'intersecting_polygons<(anonymous namespace)::AllModelSurfacesIntersectiongeode::BRep>' should be marked [[nodiscard]]
```
  559 |         std::vector< std::pair< ComponentMeshElement, ComponentMeshElement > >
      |         ^
      |         [[nodiscard]] 
```
src/geode/inspector/criterion/intersections/model_intersections.cpp:559:9: warning: [modernize-use-nodiscard]

function 'intersecting_polygons<(anonymous namespace)::AllModelSurfacesIntersectiongeode::Section>' should be marked [[nodiscard]]
```
  559 |         std::vector< std::pair< ComponentMeshElement, ComponentMeshElement > >
      |         ^
      |         [[nodiscard]] 
```
src/geode/inspector/criterion/intersections/model_intersections.cpp:559:9: warning: [modernize-use-nodiscard]

function 'intersecting_polygons<(anonymous namespace)::OneModelSurfacesIntersectiongeode::BRep>' should be marked [[nodiscard]]
```
  559 |         std::vector< std::pair< ComponentMeshElement, ComponentMeshElement > >
      |         ^
      |         [[nodiscard]] 
```
src/geode/inspector/criterion/intersections/model_intersections.cpp:559:9: warning: [modernize-use-nodiscard]

function 'intersecting_polygons<(anonymous namespace)::OneModelSurfacesIntersectiongeode::Section>' should be marked [[nodiscard]]
```
  559 |         std::vector< std::pair< ComponentMeshElement, ComponentMeshElement > >
      |         ^
      |         [[nodiscard]] 
```
src/geode/inspector/criterion/intersections/surface_intersections.cpp:82:9: warning: [modernize-use-nodiscard]

function 'mesh' should be marked [[nodiscard]]
```
   82 |         const geode::SurfaceMesh< dimension >& mesh() const
      |         ^
      |         [[nodiscard]] 
```
src/geode/inspector/criterion/intersections/surface_intersections.cpp:102:9: warning: [google-explicit-constructor]

single-argument constructors must be marked explicit to avoid unintentional implicit conversions
```
  102 |         Impl( const SurfaceMesh< dimension >& mesh )
      |         ^
      |         explicit 
```
src/geode/inspector/criterion/intersections/surface_intersections.cpp:107:9: warning: [modernize-use-nodiscard]

function 'mesh_has_self_intersections' should be marked [[nodiscard]]
```
  107 |         bool mesh_has_self_intersections() const
      |         ^
      |         [[nodiscard]] 
```

src/geode/inspector/criterion/intersections/surface_intersections.cpp:112:24: warning: [readability-simplify-boolean-expr]

redundant boolean literal in conditional return statement

  110 |             if( intersections.empty() )
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |             return !static_cast<bool>(intersections.empty())
  111 |             {
      |             ~
  112 |                 return false;
      |                 ~~~~~~~^~~~~~
  113 |             }
      |             ~
  114 |             return true;
      |             ~~~~~~~~~~~

src/geode/inspector/criterion/intersections/surface_intersections.cpp:117:9: warning: [modernize-use-nodiscard]

function 'intersecting_elements' should be marked [[nodiscard]]
```
  117 |         InspectionIssues< std::pair< index_t, index_t > >
      |         ^
      |         [[nodiscard]] 
```
src/geode/inspector/criterion/intersections/surface_intersections.cpp:135:9: warning: [modernize-use-nodiscard]

function 'intersecting_polygons' should be marked [[nodiscard]]
```
  135 |         std::vector< std::pair< index_t, index_t > > intersecting_polygons(
      |         ^
      |         [[nodiscard]] 
```
src/geode/inspector/criterion/intersections/surface_intersections.cpp:147:14: warning: [cppcoreguidelines-use-default-member-init]

use default member initializer for 'verbose_'
```
  103 |         bool verbose_;
      |              ^       
      |                      { false }
```
src/geode/inspector/criterion/manifold/solid_edge_manifold.cpp:89:9: warning: [google-explicit-constructor]

single-argument constructors must be marked explicit to avoid unintentional implicit conversions
```
   89 |         Impl( const SolidMesh< dimension >& mesh )
      |         ^
      |         explicit 
```
src/geode/inspector/criterion/manifold/solid_edge_manifold.cpp:95:9: warning: [modernize-use-nodiscard]

function 'mesh_edges_are_manifold' should be marked [[nodiscard]]
```
   95 |         bool mesh_edges_are_manifold() const
      |         ^
      |         [[nodiscard]] 
```
src/geode/inspector/criterion/manifold/solid_edge_manifold.cpp:120:9: warning: [modernize-use-nodiscard]

function 'non_manifold_edges' should be marked [[nodiscard]]
```
  120 |         InspectionIssues< std::array< index_t, 2 > > non_manifold_edges() const
      |         ^
      |         [[nodiscard]] 
```

src/geode/inspector/criterion/manifold/solid_edge_manifold.cpp:120:54: warning: [readability-function-cognitive-complexity]

function 'non_manifold_edges' has cognitive complexity of 12 (threshold 10)

  120 |         InspectionIssues< std::array< index_t, 2 > > non_manifold_edges() const
      |                                                      ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/manifold/solid_edge_manifold.cpp:126:13: note: +1, including nesting penalty of 0, nesting level increased to 1
  126 |             for( const auto polyhedron_id : Range{ mesh_.nb_polyhedra() } )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/manifold/solid_edge_manifold.cpp:128:17: note: +2, including nesting penalty of 1, nesting level increased to 2
  128 |                 for( const auto polyhedron_edge_vertices :
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/manifold/solid_edge_manifold.cpp:132:21: note: +3, including nesting penalty of 2, nesting level increased to 3
  132 |                     if( !checked_edges.insert( polyhedron_edge ).second )
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/manifold/solid_edge_manifold.cpp:138:25: note: +3, including nesting penalty of 2, nesting level increased to 3
  138 |                         if( !polyhedra_around_edge_are_the_same(
      |                         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/criterion/manifold/solid_edge_manifold.cpp:152:21: note: +3, including nesting penalty of 2, nesting level increased to 3
  152 |                     catch( const OpenGeodeException& )
      |                     ^

tests/inspector/test-brep.cpp:35:16: warning: [misc-use-internal-linkage]

function 'corners_topological_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   35 | geode::index_t corners_topological_validity(
      |                ^
      | static 
```
tests/inspector/test-brep.cpp:61:16: warning: [misc-use-internal-linkage]

function 'lines_topological_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   61 | geode::index_t lines_topological_validity(
      |                ^
      | static 
```
tests/inspector/test-brep.cpp:92:16: warning: [misc-use-internal-linkage]

function 'surfaces_topological_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   92 | geode::index_t surfaces_topological_validity(
      |                ^
      | static 
```
tests/inspector/test-brep.cpp:121:16: warning: [misc-use-internal-linkage]

function 'blocks_topological_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  121 | geode::index_t blocks_topological_validity(
      |                ^
      | static 
```
tests/inspector/test-brep.cpp:156:16: warning: [misc-use-internal-linkage]

function 'launch_topological_validity_checks' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  156 | geode::index_t launch_topological_validity_checks(
      |                ^
      | static 
```
tests/inspector/test-brep.cpp:166:16: warning: [misc-use-internal-linkage]

function 'meshes_adjacencies_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  166 | geode::index_t meshes_adjacencies_validity(
      |                ^
      | static 
```
tests/inspector/test-brep.cpp:189:16: warning: [misc-use-internal-linkage]

function 'meshes_degenerations_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  189 | geode::index_t meshes_degenerations_validity(
      |                ^
      | static 
```
tests/inspector/test-brep.cpp:217:16: warning: [misc-use-internal-linkage]

function 'meshes_intersections_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  217 | geode::index_t meshes_intersections_validity(
      |                ^
      | static 
```

tests/inspector/test-brep.cpp:218:56: warning: [performance-unnecessary-value-param]

the const qualified parameter 'result' is copied for each invocation; consider making it a reference

  218 |     const geode::ElementsIntersectionsInspectionResult result, bool string )
      |                                                        ^
      |                                                       &

tests/inspector/test-brep.cpp:232:16: warning: [misc-use-internal-linkage]

function 'meshes_manifolds_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  232 | geode::index_t meshes_manifolds_validity(
      |                ^
      | static 
```
tests/inspector/test-brep.cpp:261:16: warning: [misc-use-internal-linkage]

function 'meshes_colocations_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  261 | geode::index_t meshes_colocations_validity(
      |                ^
      | static 
```
tests/inspector/test-brep.cpp:278:16: warning: [misc-use-internal-linkage]

function 'meshes_unique_vertices_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  278 | geode::index_t meshes_unique_vertices_validity(
      |                ^
      | static 
```
tests/inspector/test-brep.cpp:297:16: warning: [misc-use-internal-linkage]

function 'launch_component_meshes_validity_checks' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  297 | geode::index_t launch_component_meshes_validity_checks(
      |                ^
      | static 
```

tests/inspector/test-brep.cpp:300:10: warning: [clang-analyzer-deadcode.DeadStores]

Value stored to 'nb_issues' during its initialization is never read

  300 |     auto nb_issues =
      |          ^~~~~~~~~
  301 |         meshes_adjacencies_validity( result.meshes_adjacencies, string );
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/OpenGeode-Inspector/OpenGeode-Inspector/tests/inspector/test-brep.cpp:300:10: note: Value stored to 'nb_issues' during its initialization is never read
  300 |     auto nb_issues =
      |          ^~~~~~~~~
  301 |         meshes_adjacencies_validity( result.meshes_adjacencies, string );
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/inspector/test-brep.cpp:315:6: warning: [misc-use-internal-linkage]

function 'check_model_a1' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  315 | void check_model_a1( bool string )
      |      ^
      | static 
```
tests/inspector/test-brep.cpp:328:34: warning: [cppcoreguidelines-avoid-magic-numbers]

5201 is a magic number; consider replacing it with a named constant
```
  328 |         nb_topological_issues == 5201, "model_A1 has ", nb_topological_issues,
      |                                  ^
```
tests/inspector/test-brep.cpp:334:39: warning: [cppcoreguidelines-avoid-magic-numbers]

13494 is a magic number; consider replacing it with a named constant
```
  334 |         nb_component_meshes_issues == 13494, "model_A1 has ",
      |                                       ^
```
tests/inspector/test-brep.cpp:338:6: warning: [misc-use-internal-linkage]

function 'check_model_a1_valid' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  338 | void check_model_a1_valid( bool string )
      |      ^
      | static 
```
tests/inspector/test-brep.cpp:351:34: warning: [cppcoreguidelines-avoid-magic-numbers]

5201 is a magic number; consider replacing it with a named constant
```
  351 |         nb_topological_issues == 5201, "model_A1_valid has ",
      |                                  ^
```
tests/inspector/test-brep.cpp:357:39: warning: [cppcoreguidelines-avoid-magic-numbers]

13494 is a magic number; consider replacing it with a named constant
```
  357 |         nb_component_meshes_issues == 13494, "model_A1_valid has ",
      |                                       ^
```
tests/inspector/test-brep.cpp:361:6: warning: [misc-use-internal-linkage]

function 'check_model_mss' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  361 | void check_model_mss( bool string )
      |      ^
      | static 
```
tests/inspector/test-brep.cpp:374:34: warning: [cppcoreguidelines-avoid-magic-numbers]

52 is a magic number; consider replacing it with a named constant
```
  374 |         nb_topological_issues == 52, "mss has ", nb_topological_issues,
      |                                  ^
```
tests/inspector/test-brep.cpp:384:6: warning: [misc-use-internal-linkage]

function 'check_model_D' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  384 | void check_model_D( bool string )
      |      ^
      | static 
```
tests/inspector/test-brep.cpp:384:6: warning: [readability-identifier-naming]

invalid case style for global function 'check_model_D'
```
  384 | void check_model_D( bool string )
      |      ^~~~~~~~~~~~~
      |      check_model_d
```
tests/inspector/test-brep.cpp:405:6: warning: [misc-use-internal-linkage]

function 'check_wrong_bsurfaces_model' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  405 | void check_wrong_bsurfaces_model()
      |      ^
      | static 
```
tests/inspector/test-brep.cpp:432:6: warning: [misc-use-internal-linkage]

function 'check_segmented_cube' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  432 | void check_segmented_cube()
      |      ^
      | static 
```

tests/inspector/test-brep.cpp:442:16: warning: [clang-analyzer-deadcode.DeadStores]

Value stored to 'nb_component_meshes_issues' during its initialization is never read

  442 |     const auto nb_component_meshes_issues =
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~
  443 |         launch_component_meshes_validity_checks( result.meshes, false );
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/__w/OpenGeode-Inspector/OpenGeode-Inspector/tests/inspector/test-brep.cpp:442:16: note: Value stored to 'nb_component_meshes_issues' during its initialization is never read
  442 |     const auto nb_component_meshes_issues =
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~
  443 |         launch_component_meshes_validity_checks( result.meshes, false );
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

tests/inspector/test-edgedcurve-colocation.cpp:33:6: warning: [misc-use-internal-linkage]

function 'check_non_colocation2D' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   33 | void check_non_colocation2D()
      |      ^
      | static 
```
tests/inspector/test-edgedcurve-colocation.cpp:33:6: warning: [readability-identifier-naming]

invalid case style for global function 'check_non_colocation2D'
```
   33 | void check_non_colocation2D()
      |      ^~~~~~~~~~~~~~~~~~~~~~
      |      check_non_colocation2_d
```
tests/inspector/test-edgedcurve-colocation.cpp:38:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   38 |     builder->set_point( 0, geode::Point2D{ { 0., 2. } } );
      |                                                  ^
```
tests/inspector/test-edgedcurve-colocation.cpp:39:46: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   39 |     builder->set_point( 1, geode::Point2D{ { 2., 0. } } );
      |                                              ^
```
tests/inspector/test-edgedcurve-colocation.cpp:40:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   40 |     builder->set_point( 2, geode::Point2D{ { 1., 4. } } );
      |                                                  ^
```
tests/inspector/test-edgedcurve-colocation.cpp:41:46: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   41 |     builder->set_point( 3, geode::Point2D{ { 3., 3. } } );
      |                                              ^
```
tests/inspector/test-edgedcurve-colocation.cpp:41:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   41 |     builder->set_point( 3, geode::Point2D{ { 3., 3. } } );
      |                                                  ^
```
tests/inspector/test-edgedcurve-colocation.cpp:52:6: warning: [misc-use-internal-linkage]

function 'check_colocation2D' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   52 | void check_colocation2D()
      |      ^
      | static 
```
tests/inspector/test-edgedcurve-colocation.cpp:52:6: warning: [readability-identifier-naming]

invalid case style for global function 'check_colocation2D'
```
   52 | void check_colocation2D()
      |      ^~~~~~~~~~~~~~~~~~
      |      check_colocation2_d
```
tests/inspector/test-edgedcurve-colocation.cpp:56:31: warning: [cppcoreguidelines-avoid-magic-numbers]

7 is a magic number; consider replacing it with a named constant
```
   56 |     builder->create_vertices( 7 );
      |                               ^
```
tests/inspector/test-edgedcurve-colocation.cpp:57:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   57 |     builder->set_point( 0, geode::Point2D{ { 0., 2. } } );
      |                                                  ^
```
tests/inspector/test-edgedcurve-colocation.cpp:58:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   58 |     builder->set_point( 1, geode::Point2D{ { 0., 2. } } );
      |                                                  ^
```
tests/inspector/test-edgedcurve-colocation.cpp:60:46: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   60 |     builder->set_point( 3, geode::Point2D{ { 2., 0. } } );
      |                                              ^
```
tests/inspector/test-edgedcurve-colocation.cpp:61:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   61 |     builder->set_point( 4, geode::Point2D{ { 1., 4. } } );
      |                                                  ^
```
tests/inspector/test-edgedcurve-colocation.cpp:63:9: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant
```
   63 |         5, geode::Point2D{ { 2., geode::GLOBAL_EPSILON / 2 } } );
      |         ^
```
tests/inspector/test-edgedcurve-colocation.cpp:63:30: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   63 |         5, geode::Point2D{ { 2., geode::GLOBAL_EPSILON / 2 } } );
      |                              ^
```
tests/inspector/test-edgedcurve-colocation.cpp:65:9: warning: [cppcoreguidelines-avoid-magic-numbers]

6 is a magic number; consider replacing it with a named constant
```
   65 |         6, geode::Point2D{ { geode::GLOBAL_EPSILON / 1.1, 2. } } );
      |         ^
```
tests/inspector/test-edgedcurve-colocation.cpp:65:54: warning: [cppcoreguidelines-avoid-magic-numbers]

1.1 is a magic number; consider replacing it with a named constant
```
   65 |         6, geode::Point2D{ { geode::GLOBAL_EPSILON / 1.1, 2. } } );
      |                                                      ^
```
tests/inspector/test-edgedcurve-colocation.cpp:65:59: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
   65 |         6, geode::Point2D{ { geode::GLOBAL_EPSILON / 1.1, 2. } } );
      |                                                           ^
```
tests/inspector/test-edgedcurve-colocation.cpp:80:32: warning: [bugprone-narrowing-conversions]

narrowing conversion from 'size_type' (aka 'unsigned long') to signed type 'int' is implementation-defined
```
   80 |         nb_colocated_points += group.size();
      |                                ^
```

tests/inspector/test-edgedcurve-colocation.cpp:82:79: warning: [cppcoreguidelines-avoid-magic-numbers]

5 is a magic number; consider replacing it with a named constant

   82 |     geode::OpenGeodeInspectorInspectorException::test( nb_colocated_points == 5,
      |                                                                               ^

tests/inspector/test-edgedcurve-colocation.cpp:98:6: warning: [misc-use-internal-linkage]

function 'check_non_colocation3D' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   98 | void check_non_colocation3D()
      |      ^
      | static 
```
tests/inspector/test-edgedcurve-colocation.cpp:98:6: warning: [readability-identifier-naming]

invalid case style for global function 'check_non_colocation3D'
```
   98 | void check_non_colocation3D()
      |      ^~~~~~~~~~~~~~~~~~~~~~
      |      check_non_colocation3_d
```
tests/inspector/test-edgedcurve-colocation.cpp:103:50: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
  103 |     builder->set_point( 0, geode::Point3D{ { 0., 2., 0. } } );
      |                                                  ^
```
tests/inspector/test-edgedcurve-colocation.cpp:104:46: warning: [cppcoreguidelines-avoid-magic-numbers]
1. is a magic number; consider replacing it with a named constant
```
  104 |     builder->set_point( 1, geode::Point3D{ { 2., 0., 0.5 } } );
      |                                              ^
```
tests/inspector/test-edgedcurve-colocation.cpp:104:54: warning: [cppcoreguidelines-avoid-magic-numbers]

0.5 is a magic number; consider replacing it with a named constant
```
  104 |     builder->set_point( 1, geode::Point3D{ { 2., 0., 0.5 } } );
      |                                                      ^
```

Have any feedback or feature suggestions? Share it here.

fix(Library): better handle exception and library

0246f1e

BotellaA requested a review from panquez April 28, 2026 06:40

panquez approved these changes Apr 28, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(Library): better handle exception and library#175

fix(Library): better handle exception and library#175
BotellaA wants to merge 1 commit intonextfrom
feat/exception-library

BotellaA commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

BotellaA commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

Cpp-Linter Report ⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants