Skip to content

[No QA] chore: upgrade react-native-screens to 4.25.0-beta.1#89199

Open
roryabraham wants to merge 7 commits intomainfrom
rory/upgrade-react-native-screens-4.25.0-beta.1
Open

[No QA] chore: upgrade react-native-screens to 4.25.0-beta.1#89199
roryabraham wants to merge 7 commits intomainfrom
rory/upgrade-react-native-screens-4.25.0-beta.1

Conversation

@roryabraham
Copy link
Copy Markdown
Contributor

@roryabraham roryabraham commented Apr 29, 2026 •
edited
Loading

Explanation of Change

Upgrades react-native-screens from 4.15.4 to 4.25.0-beta.1.

The patch react-native-screens+4.15.4+001+fix-lifecycle-events-in-fragment-host.patch was previously applied to fix lifecycle events being silently dropped when React Native is hosted inside a ReactNativeFragment (HybridApp). This fix was merged upstream in software-mansion/react-native-screens#3854 and is included in 4.25.0-beta.1, so the patch is no longer needed. I had created a reminder to upgrade this dependency after that was released, so here it is.

Also adds legacy-peer-deps=true to .npmrc since npm 7+'s strict semver resolution excludes pre-release versions from peer dependency ranges like >=4.0.0.

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

N/A — dependency upgrade only.

QA Steps

N/A — this is a dependency upgrade with no user-facing behavior changes.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@roryabraham
chore: upgrade react-native-screens to 4.25.0-beta.1
bc7e2d1 
The upstream fix for lifecycle events in fragment host (PR #3854) was
merged into react-native-screens and is included in 4.25.0-beta.1.
Remove the now-unnecessary patch.

Made-with: Cursor
@roryabraham roryabraham changed the title chore: upgrade react-native-screens to 4.25.0-beta.1 [No QA] [No QA] chore: upgrade react-native-screens to 4.25.0-beta.1 Apr 29, 2026
@sentry
Copy link
Copy Markdown

sentry Bot commented Apr 29, 2026 •
edited
Loading

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
Expensify org.me.mobiexpensifyg 9.3.64-27 (509036427) Release

⚙️ app Build Distribution Settings

@roryabraham
fix: patch SafeAreaView.web.tsx to add named export for web builds
7301495 
react-native-screens@4.25.0-beta.1 introduced SafeAreaView with only a
default export in the .web variant, causing a webpack ModuleDependencyWarning
during Storybook builds since the index re-exports it as a named export.

Made-with: Cursor
@roryabraham
fix: use npm overrides instead of legacy-peer-deps for beta version
1c5cead 
npm strict mode excludes pre-release versions from satisfying semver ranges
like >=4.0.0, so npm ci was rejecting 4.25.0-beta.1 as a peer dep satisfier.
Using npm overrides pins the version explicitly, bypassing ERESOLVE, without
changing the global resolution algorithm like legacy-peer-deps=true would.

Made-with: Cursor
@roryabraham roryabraham mentioned this pull request Apr 29, 2026
Open
1 task
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #89199 Mobile-Expensify PR Expensify/Mobile-Expensify#13929.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c3dff00-b2437fa-4fac5a8b0f02d476448c136747028d62e62e3848/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c3dff00-b2437fa-c2c89371ffa0201e657436ccd8b88eec9654c3f6/index.html
Android iOS
Web 🕸️
https://89199.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@roryabraham
Copy link
Copy Markdown
Contributor Author

roryabraham commented Apr 29, 2026 •
edited
Loading

Requested AdHoc QA of CRITICAL and HIGH regression tests: https://expensify.slack.com/archives/C09V78U42D8/p1777489250859889

@IuliiaHerets
Copy link
Copy Markdown

IuliiaHerets commented Apr 30, 2026

Regression completed
No issues found.

@roryabraham roryabraham marked this pull request as ready for review April 30, 2026 20:26
@roryabraham roryabraham requested a review from a team as a code owner April 30, 2026 20:26
@melvin-bot melvin-bot Bot requested review from arosiclair and removed request for a team April 30, 2026 20:27
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Apr 30, 2026

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arosiclair arosiclair Awaiting requested review from arosiclair

At least 1 approving review is required to merge this pull request.

Assignees

@roryabraham roryabraham

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roryabraham @IuliiaHerets