Merged
Conversation
alexslavr
force-pushed
the
lavrov/audit-alerts-2-24_2
branch
from
21998c5 to
c644517
Compare
IlyaKhD
approved these changes
Apr 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to address remaining security/audit alerts by making the build/CI flows more deterministic (frozen installs) and reducing reliance on pnpx/npx, alongside dependency updates that resolve vulnerable transitive packages.
Changes:
- Switched multiple build steps from
pnpx/npxtopnpm execand enforcedpnpm install --frozen-lockfilein CI workflows. - Added a dedicated
e2e/devextreme-bundlerworkspace project and updatedbuild_all.ymlto validatedevextreme-bundleragainst pinned bundler deps. - Updated lockfile dependencies (notably webpack/tooling graph) and adjusted a DataGrid scrolling integration test expectation.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/scripts/common/version.ts | Stops triggering a non-frozen install during version bumps. |
| tools/scripts/build-all.ts | Replaces pnpx nx ... with pnpm exec nx ... across build/pack steps. |
| pnpm-lock.yaml | Lockfile updates reflecting dependency graph changes and new workspace importer. |
| packages/devextreme/testing/tests/DevExpress.ui.widgets.dataGrid/scrolling.integration.tests.js | Updates expected scrollLeft rounding result in an integration test. |
| e2e/devextreme-bundler/package.json | Adds a workspace project to pin bundler deps for CI bundler validation. |
| .github/workflows/wrapper_tests.yml | Uses frozen lockfile install; adjusts puppeteer browser install invocation. |
| .github/workflows/demos_visual_tests_frameworks.yml | Removes old commented-out wrapper build/link steps. |
| .github/workflows/demos_visual_tests.yml | Uses pnpm install --frozen-lockfile in both jobs. |
| .github/workflows/build_all.yml | Adds checkout/pnpm setup to the bundler job and runs bundler validation via pnpm/workspace project. |
| .github/actions/setup-chrome-headless-shell/action.yml | Installs chrome-headless-shell via workspace puppeteer using pnpm instead of npx and drops apt installs. |
| .github/actions/run-qunit-tests/action.yml | Reorders steps and ensures pnpm is set up before installing deps and configuring browsers. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.