Remove deprecated startSpan and use integration name for telemetry#11181
Draft
Remove deprecated startSpan and use integration name for telemetry#11181
Conversation
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~be63ca73ed, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061880
Total [baseline] (8.859 s) : 0, 8859009
Agent [candidate] (1.055 s) : 0, 1055479
Total [candidate] (8.832 s) : 0, 8832481
section iast
Agent [baseline] (1.248 s) : 0, 1247887
Total [baseline] (9.602 s) : 0, 9602006
Agent [candidate] (1.233 s) : 0, 1232663
Total [candidate] (9.499 s) : 0, 9499234
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~be63ca73ed, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.249 ms) : 0, 1249
crashtracking [candidate] (1.218 ms) : 0, 1218
BytebuddyAgent [baseline] (638.586 ms) : 0, 638586
BytebuddyAgent [candidate] (633.718 ms) : 0, 633718
AgentMeter [baseline] (29.874 ms) : 0, 29874
AgentMeter [candidate] (29.508 ms) : 0, 29508
GlobalTracer [baseline] (250.521 ms) : 0, 250521
GlobalTracer [candidate] (248.921 ms) : 0, 248921
AppSec [baseline] (32.72 ms) : 0, 32720
AppSec [candidate] (32.22 ms) : 0, 32220
Debugger [baseline] (59.526 ms) : 0, 59526
Debugger [candidate] (58.709 ms) : 0, 58709
Remote Config [baseline] (603.514 µs) : 0, 604
Remote Config [candidate] (595.184 µs) : 0, 595
Telemetry [baseline] (8.103 ms) : 0, 8103
Telemetry [candidate] (9.404 ms) : 0, 9404
Flare Poller [baseline] (4.328 ms) : 0, 4328
Flare Poller [candidate] (5.07 ms) : 0, 5070
section iast
crashtracking [baseline] (1.245 ms) : 0, 1245
crashtracking [candidate] (1.233 ms) : 0, 1233
BytebuddyAgent [baseline] (823.304 ms) : 0, 823304
BytebuddyAgent [candidate] (810.319 ms) : 0, 810319
AgentMeter [baseline] (11.537 ms) : 0, 11537
AgentMeter [candidate] (11.408 ms) : 0, 11408
GlobalTracer [baseline] (240.405 ms) : 0, 240405
GlobalTracer [candidate] (239.347 ms) : 0, 239347
IAST [baseline] (30.185 ms) : 0, 30185
IAST [candidate] (27.478 ms) : 0, 27478
AppSec [baseline] (28.463 ms) : 0, 28463
AppSec [candidate] (30.373 ms) : 0, 30373
Debugger [baseline] (64.609 ms) : 0, 64609
Debugger [candidate] (64.596 ms) : 0, 64596
Remote Config [baseline] (545.087 µs) : 0, 545
Remote Config [candidate] (536.339 µs) : 0, 536
Telemetry [baseline] (7.801 ms) : 0, 7801
Telemetry [candidate] (7.736 ms) : 0, 7736
Flare Poller [baseline] (3.466 ms) : 0, 3466
Flare Poller [candidate] (3.458 ms) : 0, 3458
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~be63ca73ed, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063713
Total [baseline] (11.038 s) : 0, 11037909
Agent [candidate] (1.057 s) : 0, 1056944
Total [candidate] (11.053 s) : 0, 11053061
section appsec
Agent [baseline] (1.263 s) : 0, 1263310
Total [baseline] (11.046 s) : 0, 11046369
Agent [candidate] (1.272 s) : 0, 1271534
Total [candidate] (11.124 s) : 0, 11123578
section iast
Agent [baseline] (1.244 s) : 0, 1244489
Total [baseline] (11.271 s) : 0, 11270637
Agent [candidate] (1.235 s) : 0, 1235074
Total [candidate] (11.273 s) : 0, 11273044
section profiling
Agent [baseline] (1.191 s) : 0, 1191232
Total [baseline] (11.065 s) : 0, 11065199
Agent [candidate] (1.187 s) : 0, 1187321
Total [candidate] (11.058 s) : 0, 11058231
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~be63ca73ed, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.242 ms) : 0, 1242
crashtracking [candidate] (1.221 ms) : 0, 1221
BytebuddyAgent [baseline] (639.287 ms) : 0, 639287
BytebuddyAgent [candidate] (634.854 ms) : 0, 634854
AgentMeter [baseline] (29.721 ms) : 0, 29721
AgentMeter [candidate] (29.569 ms) : 0, 29569
GlobalTracer [baseline] (250.493 ms) : 0, 250493
GlobalTracer [candidate] (249.697 ms) : 0, 249697
AppSec [baseline] (32.486 ms) : 0, 32486
AppSec [candidate] (32.42 ms) : 0, 32420
Debugger [baseline] (60.14 ms) : 0, 60140
Debugger [candidate] (59.907 ms) : 0, 59907
Remote Config [baseline] (605.037 µs) : 0, 605
Remote Config [candidate] (592.712 µs) : 0, 593
Telemetry [baseline] (8.132 ms) : 0, 8132
Telemetry [candidate] (8.013 ms) : 0, 8013
Flare Poller [baseline] (5.2 ms) : 0, 5200
Flare Poller [candidate] (4.409 ms) : 0, 4409
section appsec
crashtracking [baseline] (1.219 ms) : 0, 1219
crashtracking [candidate] (1.244 ms) : 0, 1244
BytebuddyAgent [baseline] (676.516 ms) : 0, 676516
BytebuddyAgent [candidate] (680.604 ms) : 0, 680604
AgentMeter [baseline] (12.276 ms) : 0, 12276
AgentMeter [candidate] (12.33 ms) : 0, 12330
GlobalTracer [baseline] (249.096 ms) : 0, 249096
GlobalTracer [candidate] (250.825 ms) : 0, 250825
AppSec [baseline] (187.884 ms) : 0, 187884
AppSec [candidate] (187.298 ms) : 0, 187298
Debugger [baseline] (64.013 ms) : 0, 64013
Debugger [candidate] (66.265 ms) : 0, 66265
Remote Config [baseline] (576.987 µs) : 0, 577
Remote Config [candidate] (587.291 µs) : 0, 587
Telemetry [baseline] (7.8 ms) : 0, 7800
Telemetry [candidate] (7.91 ms) : 0, 7910
Flare Poller [baseline] (3.379 ms) : 0, 3379
Flare Poller [candidate] (3.471 ms) : 0, 3471
IAST [baseline] (24.172 ms) : 0, 24172
IAST [candidate] (24.423 ms) : 0, 24423
section iast
crashtracking [baseline] (1.245 ms) : 0, 1245
crashtracking [candidate] (1.233 ms) : 0, 1233
BytebuddyAgent [baseline] (820.201 ms) : 0, 820201
BytebuddyAgent [candidate] (812.332 ms) : 0, 812332
AgentMeter [baseline] (11.519 ms) : 0, 11519
AgentMeter [candidate] (11.367 ms) : 0, 11367
GlobalTracer [baseline] (239.914 ms) : 0, 239914
GlobalTracer [candidate] (238.967 ms) : 0, 238967
AppSec [baseline] (27.735 ms) : 0, 27735
AppSec [candidate] (28.629 ms) : 0, 28629
Debugger [baseline] (64.908 ms) : 0, 64908
Debugger [candidate] (65.487 ms) : 0, 65487
Remote Config [baseline] (548.958 µs) : 0, 549
Remote Config [candidate] (538.504 µs) : 0, 539
Telemetry [baseline] (7.863 ms) : 0, 7863
Telemetry [candidate] (7.777 ms) : 0, 7777
Flare Poller [baseline] (3.485 ms) : 0, 3485
Flare Poller [candidate] (3.453 ms) : 0, 3453
IAST [baseline] (30.71 ms) : 0, 30710
IAST [candidate] (29.057 ms) : 0, 29057
section profiling
ProfilingAgent [baseline] (94.482 ms) : 0, 94482
ProfilingAgent [candidate] (94.879 ms) : 0, 94879
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (695.58 ms) : 0, 695580
BytebuddyAgent [candidate] (693.036 ms) : 0, 693036
AgentMeter [baseline] (9.05 ms) : 0, 9050
AgentMeter [candidate] (8.99 ms) : 0, 8990
GlobalTracer [baseline] (208.925 ms) : 0, 208925
GlobalTracer [candidate] (207.482 ms) : 0, 207482
AppSec [baseline] (32.512 ms) : 0, 32512
AppSec [candidate] (32.49 ms) : 0, 32490
Debugger [baseline] (65.872 ms) : 0, 65872
Debugger [candidate] (65.795 ms) : 0, 65795
Remote Config [baseline] (574.006 µs) : 0, 574
Remote Config [candidate] (588.472 µs) : 0, 588
Telemetry [baseline] (7.781 ms) : 0, 7781
Telemetry [candidate] (7.948 ms) : 0, 7948
Flare Poller [baseline] (3.507 ms) : 0, 3507
Flare Poller [candidate] (3.521 ms) : 0, 3521
Profiling [baseline] (95.039 ms) : 0, 95039
Profiling [candidate] (95.439 ms) : 0, 95439
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 4 performance regressions! Performance is the same for 15 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~be63ca73ed, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section baseline
no_agent (1.266 ms) : 1254, 1279
. : milestone, 1266,
iast (3.314 ms) : 3271, 3356
. : milestone, 3314,
iast_FULL (5.982 ms) : 5921, 6042
. : milestone, 5982,
iast_GLOBAL (3.69 ms) : 3631, 3749
. : milestone, 3690,
profiling (2.089 ms) : 2072, 2107
. : milestone, 2089,
tracing (1.88 ms) : 1864, 1895
. : milestone, 1880,
section candidate
no_agent (1.243 ms) : 1231, 1255
. : milestone, 1243,
iast (3.292 ms) : 3244, 3340
. : milestone, 3292,
iast_FULL (6.107 ms) : 6044, 6171
. : milestone, 6107,
iast_GLOBAL (3.747 ms) : 3684, 3809
. : milestone, 3747,
profiling (2.5 ms) : 2475, 2525
. : milestone, 2500,
tracing (1.943 ms) : 1925, 1961
. : milestone, 1943,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~be63ca73ed, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section baseline
no_agent (19.35 ms) : 19150, 19551
. : milestone, 19350,
appsec (18.903 ms) : 18709, 19096
. : milestone, 18903,
code_origins (17.581 ms) : 17412, 17751
. : milestone, 17581,
iast (18.106 ms) : 17924, 18289
. : milestone, 18106,
profiling (18.3 ms) : 18116, 18484
. : milestone, 18300,
tracing (17.953 ms) : 17778, 18128
. : milestone, 17953,
section candidate
no_agent (17.993 ms) : 17811, 18174
. : milestone, 17993,
appsec (18.513 ms) : 18325, 18700
. : milestone, 18513,
code_origins (18.144 ms) : 17962, 18325
. : milestone, 18144,
iast (17.882 ms) : 17704, 18060
. : milestone, 17882,
profiling (19.583 ms) : 19383, 19784
. : milestone, 19583,
tracing (17.861 ms) : 17681, 18040
. : milestone, 17861,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~be63ca73ed, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section baseline
no_agent (1.488 ms) : 1476, 1500
. : milestone, 1488,
appsec (3.855 ms) : 3629, 4081
. : milestone, 3855,
iast (2.279 ms) : 2209, 2348
. : milestone, 2279,
iast_GLOBAL (2.322 ms) : 2252, 2392
. : milestone, 2322,
profiling (2.097 ms) : 2043, 2152
. : milestone, 2097,
tracing (2.074 ms) : 2020, 2127
. : milestone, 2074,
section candidate
no_agent (1.487 ms) : 1476, 1499
. : milestone, 1487,
appsec (2.539 ms) : 2485, 2594
. : milestone, 2539,
iast (2.275 ms) : 2205, 2344
. : milestone, 2275,
iast_GLOBAL (2.318 ms) : 2248, 2388
. : milestone, 2318,
profiling (2.094 ms) : 2039, 2148
. : milestone, 2094,
tracing (2.084 ms) : 2030, 2137
. : milestone, 2084,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~be63ca73ed, baseline=1.62.0-SNAPSHOT~d4d2069709
dateFormat X
axisFormat %s
section baseline
no_agent (15.271 s) : 15271000, 15271000
. : milestone, 15271000,
appsec (14.65 s) : 14650000, 14650000
. : milestone, 14650000,
iast (18.651 s) : 18651000, 18651000
. : milestone, 18651000,
iast_GLOBAL (17.791 s) : 17791000, 17791000
. : milestone, 17791000,
profiling (15.067 s) : 15067000, 15067000
. : milestone, 15067000,
tracing (14.886 s) : 14886000, 14886000
. : milestone, 14886000,
section candidate
no_agent (14.967 s) : 14967000, 14967000
. : milestone, 14967000,
appsec (15.05 s) : 15050000, 15050000
. : milestone, 15050000,
iast (18.847 s) : 18847000, 18847000
. : milestone, 18847000,
iast_GLOBAL (17.797 s) : 17797000, 17797000
. : milestone, 17797000,
profiling (14.85 s) : 14850000, 14850000
. : milestone, 14850000,
tracing (14.78 s) : 14780000, 14780000
. : milestone, 14780000,
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
2c0be96 to
56db67f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Removes the 4 deprecated
startSpanoverloads fromAgentTracerthat accepted aCharSequencespan name as the only/first argument and defaulted to"datadog"as the instrumentation name:All ~145 call sites across ~143 instrumentation files have been migrated to the non-deprecated form that explicitly passes the integration's own name as the first
Stringargument (matchinginstrumentationNames()[0]from the nearest decorator). This ensures spans are attributed to the correct integration rather than the generic"datadog"default.The private
DEFAULT_INSTRUMENTATION_NAME = "datadog"constant inAgentTraceris also removed; the two remaining deprecated methods inTracerAPI(buildSpan(CharSequence)andsingleSpanBuilder(CharSequence)) now inline the"datadog"literal directly.No behaviour change — this is a pure refactor. The instrumentation name passed to the tracer now matches what each integration already declared as its own name.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.