Skip to content

Glasgow | 26-ITP-Jan| Martin McLean |Sprint 2|Book Library #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mjm-git185 wants to merge 7 commits into
base: main
Choose a base branch
from
+69 −68
Open

Glasgow | 26-ITP-Jan| Martin McLean |Sprint 2|Book Library #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3d8b1b7
librery should work as expected now
mjm-git185 Apr 16, 2026
b0f2a10
file fixed
mjm-git185 Apr 16, 2026
c2e4d17
made a start on the refactor stuck on how to clear the table at top o…
mjm-git185 Apr 17, 2026
cd3f7dd
i think i got it
mjm-git185 Apr 17, 2026
6757af6
12 of the 13 issuse adressed haveing some trouble with the delete order
mjm-git185 Apr 17, 2026
e9c75a0
this should be it
mjm-git185 Apr 18, 2026
5fe0c91
Clerical Error
mjm-git185 Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions debugging/book-library/index.html
View file
Open in desktop
Comment thread
cjyuan marked this conversation as resolved.
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<title>Library Books</title>
<meta charset="utf-8" />
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
Expand All @@ -31,18 +27,20 @@ <h1>Library</h1>
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
placeholder="Title"
required
/>
<label for="author">Author: </label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
placeholder="Author"
required
/>
<label for="pages">Pages:</label>
Expand All @@ -51,6 +49,9 @@ <h1>Library</h1>
class="form-control"
id="pages"
name="pages"
placeholder="Between 1 and 16000"
min="1"
max="16000"
Comment thread
cjyuan marked this conversation as resolved.
required
/>
<label class="form-check-label">
Expand Down
118 changes: 59 additions & 59 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,103 +1,103 @@
let myLibrary = [];
const myLibrary = [];

window.addEventListener("load", function (e) {
window.addEventListener("load", function () {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
if (myLibrary.length === 0) {
const book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
const book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
"500",
true
);
myLibrary.push(book1);
myLibrary.push(book2);
myLibrary.push(book1, book2);

render();
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function

function submit() {
const titleInput = document.getElementById("title").value.trim();
const authorInput = document.getElementById("author").value.trim();
const pagesInput = Number(document.getElementById("pages").value);
const checkInput = document.getElementById("check").checked;
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
titleInput == "" ||
pagesInput == "" ||
authorInput == "" ||
pagesInput == NaN ||
pagesInput < 1 ||
pagesInput > 16000
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
let book = new Book(titleInput, authorInput, pagesInput, checkInput);
Comment thread
cjyuan marked this conversation as resolved.
myLibrary.push(book);
render();
}
}

function Book(title, author, pages, check) {
this.title = title;
this.author = author;
this.pages = pages;
this.check = check;
function Book(titleInput, authorInput, pagesInput, checkInput) {
this.title = titleInput;
this.author = authorInput;
this.pages = pagesInput;
this.check = checkInput;
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
const table = document.getElementById("display");
const rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
while (table.rows.length > 1) {
table.deleteRow(1);
}
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearing <tbody> is probably easier and more efficient.


//insert updated row and cells
let length = myLibrary.length;
const length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
const row = table.insertRow(1);
const titleCell = row.insertCell(0);
const authorCell = row.insertCell(1);
const pagesCell = row.insertCell(2);
const wasReadCell = row.insertCell(3);
const deleteCell = row.insertCell(4);
titleCell.textContent = myLibrary[i].title;
authorCell.textContent = myLibrary[i].author;
pagesCell.textContent = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
const changeButton = document.createElement("button");

changeButton.className = "btn btn-success";
wasReadCell.appendChild(changeButton);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;

changeBut.addEventListener("click", function () {
myLibrary[i].check ? (readStatus = "Yes") : (readStatus = "No");

changeButton.innerText = readStatus;

changeButton.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;

render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
const button = document.createElement("button");
deleteCell.appendChild(button);
button.className = "btn btn-warning";
button.textContent = "Delete";
button.addEventListener("click", function () {
const deletedBook = myLibrary[i].title;
myLibrary.splice(i, 1);

render();
alert(`You've deleted title: ${deletedBook}`);
});
}
}
Loading