Skip to content

Fix: Truncate long custom state names in filter menu (AST-137779) #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cx-aniket-shinde merged 2 commits into from
Apr 20, 2026
Merged

Fix: Truncate long custom state names in filter menu (AST-137779) #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58aa636
Fix AST-137779: Truncate long custom state names in filter menu and t…
cx-aniket-shinde Apr 15, 2026
b596084
Fix AST-137779: Guard against null getResults() in cxProjectMatchesWo…
cx-aniket-shinde Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions checkmarx-ast-eclipse-plugin/src/com/checkmarx/eclipse/views/CheckmarxView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -626,6 +626,13 @@ private void createResultViewPanel(Composite resultsComposite) {
combo_1.setLayoutData(gd_combo_1);

triageStateComboViewer = new ComboViewer(triageView, SWT.READ_ONLY);
triageStateComboViewer.setLabelProvider(new LabelProvider() {
@Override
public String getText(Object element) {
String s = element instanceof String ? (String) element : super.getText(element);
return s.length() > 50 ? s.substring(0, 47) + "..." : s;
}
});
Combo combo_2 = triageStateComboViewer.getCombo();
combo_2.setEnabled(true);
combo_2.setData(PluginConstants.DATA_ID_KEY, PluginConstants.TRIAGE_STATE_COMBO_ID);
Expand Down
6 changes: 5 additions & 1 deletion ...t-eclipse-plugin/src/com/checkmarx/eclipse/views/actions/ActionFilterStatePreference.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public Menu getMenu(final Control parent) {

for (String customState : customStates) {
MenuItem item = new MenuItem(menu, SWT.CHECK);
item.setText(customState);
item.setText(truncate(customState));
item.setSelection(FilterState.isCustomStateSelected(customState));
item.addSelectionListener(new SelectionAdapter() {
@Override
Expand Down Expand Up @@ -127,4 +127,8 @@ public void widgetSelected(SelectionEvent e) {
public Menu getMenu(final Menu parent) {
return null;
}

private static String truncate(String text) {
return text.length() > 50 ? text.substring(0, 47) + "..." : text;
}
}
2 changes: 1 addition & 1 deletion checkmarx-ast-eclipse-plugin/src/com/checkmarx/eclipse/views/actions/ActionStartScan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ private String getCurrentGitBranch() {
*/
private boolean cxProjectMatchesWorkspaceProject() {
Results results = DataProvider.getInstance().getCurrentResults();
boolean noResultsInScan = results == null || results.getResults().isEmpty();
boolean noResultsInScan = results == null || results.getResults() == null || results.getResults().isEmpty();
boolean noFilesInWorkspace = ResourcesPlugin.getWorkspace().getRoot().getProjects().length == 0;

if (noResultsInScan || noFilesInWorkspace) {
Expand Down
Loading