Update share link attributes for accessibility#485
Merged
Conversation
francoistibo
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a11y pour les liens de partage.
L'attribut title n'est pas nécessaire, car il y a déjà un élément sr-only dans le lien qui fait doublon.
De plus cela n'était pas conforme car il ne reprenait pas l'intitulé visible "Nouvelle fenêtre" ajouté par le
the_linkNote
Low Risk
Low risk: mainly adjusts share link labeling for accessibility and regenerates translation catalogs; behavior changes are limited to link markup text/attributes.
Overview
Updates share button generation to stop using the HTML
titleattribute for network labels, and instead uses a dedicatedaccessible_namestring rendered in the existingsr-onlyspan (including renaming the email label to “Share by email”).Regenerates i18n files (
beapi-frontend-framework.pot,fr_FR.po) to reflect the new/updated strings and updated source references/metadata.Reviewed by Cursor Bugbot for commit e4ec8dd. Bugbot is set up for automated code reviews on this repo. Configure here.