Add Korean (`ko`) language support to frontend translations and language registry by Copilot · Pull Request #6 · Azure-Samples/DevOpsEngineerPersona

Copilot · 2026-04-17T18:41:15Z

This PR adds Korean as a supported app language by introducing a new translation module and registering ko in the language system consumed by LanguageProvider and language selection flows.

Language registration
- Added ko to Language union and LANGUAGES metadata in src/lib/types.ts
- Added Korean display metadata (한국어, 🇰🇷) so it appears in the language toggle
- Registered ko in src/lib/translations/index.ts
Korean translation file
- Added src/lib/translations/ko.ts
- Preserved Zava brand naming and localized key home-screen labels for Korean entry flow
Frontend API language typing consistency
- Extended language unions in src/lib/api.ts to include ko where language codes are passed through client API helpers
E2E coverage update
- Updated language URL-parameter coverage in e2e/app.spec.ts to include ?lang=ko and assert Korean UI text

// src/lib/translations/index.ts
import { ko } from './ko'

export const translations = {
  en, es, pt, fr, it, ja, ko, zh, de, nl
}

Documentation
- Added Korean to the translation language list in src/lib/translations/README.md

Korean UI preview:
https://github.com/user-attachments/assets/4b0c049f-1fbd-4e2f-ac92-908db7b62e55

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

cdn.functions.azure.com
- Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node lib/install.js (dns block)
fonts.googleapis.com
- Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1217/chrome-headless-shell-linux64/chrome-headless-shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1217/chrome-headless-shell-linux64/chrome-headless-shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Transl gineerPersona/api/node_modules/.bin/jest (dns block)
- Triggering command: /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1217/chrome-headless-shell-linux64/chrome-headless-shell /home/REDACTED/.cache/ms-playwright/chromium_headless_shell-1217/chrome-headless-shell-linux64/chrome-headless-shell --disable-field-trial-config --disable-REDACTED-networking --disable-REDACTED-timer-throttling --disable-REDACTEDing-occluded-windows --disable-back-forward-cache --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-REDACTED-pages --disable-component-update --no-default-browser-check --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=AvoidUnnecessaryBeforeUnloadCheckSync,BoundaryEventDispatchTracksNodeRemoval,DestroyProfileOnBrowserClose,DialMediaRouteProvider,GlobalMediaControls,HttpsUpgrades,LensOverlay,MediaRouter,PaintHolding,ThirdPartyStoragePartitioning,Transl k/node_modules/.bin/node (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Agent-Logs-Url: https://github.com/Azure-Samples/DevOpsEngineerPersona/sessions/29ca39b7-971a-4aca-8545-5da6c3b00dbd Co-authored-by: dsanchezcr <10506023+dsanchezcr@users.noreply.github.com>

github-actions · 2026-04-17T19:04:56Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-bay-0c9784b0f-6.eastus2.7.azurestaticapps.net

Copilot

Pull request overview

Adds Korean (ko) as a selectable frontend language by extending the language registry/types, registering a new translation module, and updating E2E coverage to exercise ?lang=ko.

Changes:

Extend the frontend Language union + LANGUAGES metadata to include ko.
Add and register src/lib/translations/ko.ts in the translation aggregator.
Update client API helper language typings and expand E2E coverage for ?lang=ko.

Show a summary per file

File	Description
`src/lib/types.ts`	Adds `ko` to the `Language` union and registers Korean in `LANGUAGES` for UI selection.
`src/lib/translations/ko.ts`	Introduces Korean translations (currently implemented as partial overrides on top of `en`).
`src/lib/translations/index.ts`	Imports and exports the new `ko` translation module.
`src/lib/translations/README.md`	Documents Korean as an available translation file.
`src/lib/api.ts`	Extends the client-side `language` unions to include `ko` for API payloads/calls.
`e2e/app.spec.ts`	Adds coverage for `?lang=ko` and broadens the “multi-language” UI assertion.

Copilot's findings

Files reviewed: 6/6 changed files
Comments generated: 4

Copilot · 2026-04-17T19:18:40Z

+  language?: 'en' | 'es' | 'pt' | 'fr' | 'it' | 'ja' | 'ko' | 'zh' | 'de' | 'nl'
 }


The language union is duplicated in multiple API payload/signature types in this file, which required updating many call sites just to add ko. To reduce future drift/omissions, consider importing and reusing the Language type from src/lib/types.ts (you already import Game from there) and referencing it here instead of repeating the union.

Copilot · 2026-04-17T19:18:41Z

+export const ko = {
+  ...en,
+  appName: 'Zava 선물 교환',
+  welcome: '환영합니다!',
+  welcomeDesc: '쉽고 재미있게 선물 교환을 준비하세요',
+  createGame: '새 게임 만들기',
+  joinGame: '게임 참가하기',


ko.ts is implemented as a partial override (...en) and leaves most strings in English. This conflicts with the translations README guidance for adding a new language (“Translate all strings”) and will result in a mixed Korean/English UI once users select Korean. Either complete the Korean translations before exposing ko in the language toggle, or explicitly document/label Korean as a partial/beta translation and keep the fallback approach intentional.

Copilot · 2026-04-17T19:18:41Z

+import { en } from './en'
+
+export const ko = {
+  ...en,
+  appName: 'Zava 선물 교환',
+  welcome: '환영합니다!',
+  welcomeDesc: '쉽고 재미있게 선물 교환을 준비하세요',
+  createGame: '새 게임 만들기',
+  joinGame: '게임 참가하기',
+  enterCode: '코드를 입력하세요',
+  codePlaceholder: '6자리 코드',
+  continue: '계속',
+  back: '뒤로',
+  next: '다음',
+  finish: '완료',
+  cancel: '취소',
+  confirm: '확인',
+  language: '언어',
+  darkMode: '다크 모드',
+  lightMode: '라이트 모드',
+  privacyLink: '개인정보 처리방침',
+  guideOrganizerLink: '주최자 가이드',
+  guideParticipantLink: '참가자 가이드',
+  guideOrganizerTitle: '주최자 가이드',
+  guideParticipantTitle: '참가자 가이드'


Style in src/lib/translations/* appears consistent (double quotes + no en import/spread in existing language files like de.ts, es.ts). ko.ts currently uses single quotes and different formatting, which makes the translations directory inconsistent and harder to maintain. Consider matching the existing translation file formatting for consistency.

Suggested change

import { en } from './en'

export const ko = {

...en,

appName: 'Zava 선물 교환',

welcome: '환영합니다!',

welcomeDesc: '쉽고 재미있게 선물 교환을 준비하세요',

createGame: '새 게임 만들기',

joinGame: '게임 참가하기',

enterCode: '코드를 입력하세요',

codePlaceholder: '6자리 코드',

continue: '계속',

back: '뒤로',

next: '다음',

finish: '완료',

cancel: '취소',

confirm: '확인',

language: '언어',

darkMode: '다크 모드',

lightMode: '라이트 모드',

privacyLink: '개인정보 처리방침',

guideOrganizerLink: '주최자 가이드',

guideParticipantLink: '참가자 가이드',

guideOrganizerTitle: '주최자 가이드',

guideParticipantTitle: '참가자 가이드'

export const ko = {

appName: "Zava 선물 교환",

welcome: "환영합니다!",

welcomeDesc: "쉽고 재미있게 선물 교환을 준비하세요",

createGame: "새 게임 만들기",

joinGame: "게임 참가하기",

enterCode: "코드를 입력하세요",

codePlaceholder: "6자리 코드",

continue: "계속",

back: "뒤로",

next: "다음",

finish: "완료",

cancel: "취소",

confirm: "확인",

language: "언어",

darkMode: "다크 모드",

lightMode: "라이트 모드",

privacyLink: "개인정보 처리방침",

guideOrganizerLink: "주최자 가이드",

guideParticipantLink: "참가자 가이드",

guideOrganizerTitle: "주최자 가이드",

guideParticipantTitle: "참가자 가이드"

Copilot · 2026-04-17T19:18:41Z

+  language?: 'en' | 'es' | 'pt' | 'fr' | 'it' | 'ja' | 'ko' | 'zh' | 'de' | 'nl'
 }


ko is now allowed in the client-side language field, but the backend email pipeline does not support it today. api/src/shared/types.ts’s Language union excludes ko, and several email template generators index translations via translations[language] without a fallback (e.g. api/src/shared/email-service.ts:371), so sending emails while language='ko' will likely throw at runtime and fail game creation / email sends. Either add ko support server-side (types + templates or robust fallback), or avoid sending ko to the API until the backend can safely handle it (e.g., normalize to en for email-related calls).

github-actions · 2026-04-17T19:20:54Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-grass-0fb1b520f-6.eastus2.7.azurestaticapps.net

github-actions · 2026-04-17T19:52:50Z

🧹 Preview Environment Cleaned Up

Resource group ZavaGiftExchange-pr-6 is being deleted.

All Azure resources for this PR have been removed.

Initial plan

4045197

Copilot AI assigned Copilot and dsanchezcr Apr 17, 2026

Copilot started work on behalf of dsanchezcr April 17, 2026 18:41 View session

Copilot AI linked an issue Apr 17, 2026 that may be closed by this pull request

Add support for a new language: Korean add the translation file and register it in the LanguageProvider #5

Closed

Copilot AI and others added 3 commits April 17, 2026 18:47

feat: add Korean language support and registration

26dbd64

Agent-Logs-Url: https://github.com/Azure-Samples/DevOpsEngineerPersona/sessions/29ca39b7-971a-4aca-8545-5da6c3b00dbd Co-authored-by: dsanchezcr <10506023+dsanchezcr@users.noreply.github.com>

refactor: improve Korean home screen translation coverage

6c880ff

Agent-Logs-Url: https://github.com/Azure-Samples/DevOpsEngineerPersona/sessions/29ca39b7-971a-4aca-8545-5da6c3b00dbd Co-authored-by: dsanchezcr <10506023+dsanchezcr@users.noreply.github.com>

fix: preserve Zava brand name in Korean translation

945a1eb

Agent-Logs-Url: https://github.com/Azure-Samples/DevOpsEngineerPersona/sessions/29ca39b7-971a-4aca-8545-5da6c3b00dbd Co-authored-by: dsanchezcr <10506023+dsanchezcr@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add support for a new language: Korean~~ Add Korean (ko) language support to frontend translations and language registry Apr 17, 2026

Copilot AI requested a review from dsanchezcr April 17, 2026 18:52

Copilot finished work on behalf of dsanchezcr April 17, 2026 18:52

Copilot AI deployed to pr April 17, 2026 19:03 View deployment

Merge branch 'main' into copilot/add-korean-language-support

ce4aa8f

dsanchezcr marked this pull request as ready for review April 17, 2026 19:13

Copilot AI review requested due to automatic review settings April 17, 2026 19:13

Copilot started reviewing on behalf of dsanchezcr April 17, 2026 19:13 View session

Copilot AI reviewed Apr 17, 2026

View reviewed changes

dsanchezcr deployed to pr April 17, 2026 19:18 — with GitHub Actions View deployment

dsanchezcr merged commit b72e86b into main Apr 17, 2026
21 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Korean (`ko`) language support to frontend translations and language registry#6

Add Korean (`ko`) language support to frontend translations and language registry#6
dsanchezcr merged 5 commits intomainfrom
copilot/add-korean-language-support

Copilot AI commented Apr 17, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 17, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

Copilot AI Apr 17, 2026

Uh oh!

github-actions Bot commented Apr 17, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		language?: 'en' \| 'es' \| 'pt' \| 'fr' \| 'it' \| 'ja' \| 'ko' \| 'zh' \| 'de' \| 'nl'
		}

Conversation

Copilot AI commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

github-actions Bot commented Apr 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 17, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 17, 2026

🧹 Preview Environment Cleaned Up

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 17, 2026 •

edited

Loading