Skip to content

fix: show full error when terminal installation fails #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bajrangCoder merged 2 commits into from
Apr 28, 2026
Merged

fix: show full error when terminal installation fails #2070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ad61fd
fix: show full error when terminal installation fails
bajrangCoder Apr 28, 2026
bfcfd2d
fix
bajrangCoder Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions src/components/terminal/terminalManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,12 +442,12 @@ class TerminalManager {
const installResult = await Terminal.install(
(message) => {
// Remove stdout/stderr prefix for
const cleanMessage = message.replace(/^(stdout|stderr)\s+/, "");
const cleanMessage = this.formatInstallLog(message);
installTerminal.component.write(`${cleanMessage}\r\n`);
},
(error) => {
(...errorParts) => {
// Remove stdout/stderr prefix
const cleanError = error.replace(/^(stdout|stderr)\s+/, "");
const cleanError = this.formatInstallLog(errorParts);
installTerminal.component.write(
`\x1b[31mError: ${cleanError}\x1b[0m\r\n`,
);
Expand All @@ -458,21 +458,34 @@ class TerminalManager {
if (installResult === true) {
return { success: true };
} else {
const error =
Terminal.lastInstallError ||
"Terminal installation failed - process did not exit with code 0";
return {
success: false,
error:
"Terminal installation failed - process did not exit with code 0",
error,
};
}
} catch (error) {
console.error("Terminal installation failed:", error);
return {
success: false,
error: `Terminal installation failed: ${error.message}`,
error: `Terminal installation failed: ${this.formatInstallLog(error)}`,
};
}
}

formatInstallLog(value) {
const values = Array.isArray(value) ? value : [value];
const message = values
.filter((entry) => entry != null)
.map((entry) => Terminal.formatError(entry))
.filter(Boolean)
.join(" ");

return message.replace(/^(stdout|stderr)\s+/, "") || "Unknown error";
}
Comment thread
bajrangCoder marked this conversation as resolved.

/**
* Create a terminal for showing installation progress
* @returns {Promise<object>} Installation terminal instance
Expand Down
255 changes: 148 additions & 107 deletions src/plugins/terminal/www/Terminal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,56 +13,55 @@ const Terminal = {
system.getFilesDir(resolve, reject);
});

if (installing) {
return new Promise((resolve, reject) => {
readAsset("init-alpine.sh", async (content) => {
system.writeText(`${filesDir}/init-alpine.sh`, content, logger, err_logger);
});

readAsset("rm-wrapper.sh", async (content) => {
system.deleteFile(`${filesDir}/alpine/bin/rm`, logger, err_logger);
system.writeText(`${filesDir}/alpine/bin/rm`, content, logger, err_logger);
system.setExec(`${filesDir}/alpine/bin/rm`, true, logger, err_logger);
});

readAsset("init-sandbox.sh", (content) => {
system.writeText(`${filesDir}/init-sandbox.sh`, content, logger, err_logger);

Executor.start("sh", (type, data) => {
logger(`${type} ${data}`);
const [initAlpine, rmWrapper, initSandbox] = await Promise.all([
readAsset("init-alpine.sh"),
readAsset("rm-wrapper.sh"),
readAsset("init-sandbox.sh"),
]);

// Check for exit code during installation
if (type === "exit") {
resolve(data === "0");
}
}).then(async (uuid) => {
await Executor.write(uuid, `source ${filesDir}/init-sandbox.sh ${installing ? "--installing" : ""}; exit`);
}).catch((error) => {
err_logger("Failed to start AXS:", error);
resolve(false);
});
});
});
} else {
readAsset("rm-wrapper.sh", async (content) => {
system.deleteFile(`${filesDir}/alpine/bin/rm`, logger, err_logger);
system.writeText(`${filesDir}/alpine/bin/rm`, content, logger, err_logger);
system.setExec(`${filesDir}/alpine/bin/rm`, true, logger, err_logger);
});
await writeText(`${filesDir}/init-alpine.sh`, initAlpine);
await writeText(`${filesDir}/init-sandbox.sh`, initSandbox);

readAsset("init-alpine.sh", async (content) => {
system.writeText(`${filesDir}/init-alpine.sh`, content, logger, err_logger);
});
await deleteFile(`${filesDir}/alpine/bin/rm`).catch(() => {});
await writeText(`${filesDir}/alpine/bin/rm`, rmWrapper);
await setExec(`${filesDir}/alpine/bin/rm`, true);

readAsset("init-sandbox.sh", (content) => {
system.writeText(`${filesDir}/init-sandbox.sh`, content, logger, err_logger);
if (installing) {
return new Promise((resolve, reject) => {
let lastError = "";

Executor.start("sh", (type, data) => {
logger(`${type} ${data}`);

if (type === "stderr" && data) {
lastError = lastError ? `${lastError}\n${data}` : data;
}

// Check for exit code during installation
if (type === "exit") {
const success = data === "0";
if (!success) {
this.lastInstallError = lastError
? `Sandbox configuration failed with exit code ${data}: ${lastError}`
: `Sandbox configuration failed with exit code ${data}`;
}
resolve(success);
Comment thread
bajrangCoder marked this conversation as resolved.
}
}).then(async (uuid) => {
await Executor.write(uuid, `source ${filesDir}/init-sandbox.sh ${installing ? "--installing" : ""}; exit`);
}).catch((error) => {
const message = `Failed to start AXS: ${formatError(error)}`;
this.lastInstallError = message;
err_logger(message);
resolve(false);
});
});
} else {
Executor.start("sh", (type, data) => {
logger(`${type} ${data}`);
}).then(async (uuid) => {
await Executor.write(uuid, `source ${filesDir}/init-sandbox.sh ${installing ? "--installing" : ""}; exit`);
});
}
},

Expand Down Expand Up @@ -104,6 +103,7 @@ const Terminal = {
*/
async install(logger = console.log, err_logger = console.error) {
if (!(await this.isSupported())) return false;
this.lastInstallError = "";

try {
//cleanup before insatll
Expand Down Expand Up @@ -154,62 +154,26 @@ const Terminal = {


logger("⬇️ Downloading sandbox filesystem...");
await new Promise((resolve, reject) => {
cordova.plugin.http.downloadFile(
alpineUrl, {}, {},
cordova.file.dataDirectory + "alpine.tar.gz",
resolve, reject
);
});
await downloadFile(alpineUrl, cordova.file.dataDirectory + "alpine.tar.gz", "Sandbox filesystem");

logger("⬇️ Downloading axs...");
await new Promise((resolve, reject) => {
cordova.plugin.http.downloadFile(
axsUrl, {}, {},
cordova.file.dataDirectory + "axs",
resolve, reject
);
});
await downloadFile(axsUrl, cordova.file.dataDirectory + "axs", "AXS");

const isFdroid = await Executor.execute("echo $FDROID");
if (isFdroid === "true") {
logger("🐧 F-Droid flavor detected, downloading additional files...");
logger("⬇️ Downloading compatibility layer...");
await new Promise((resolve, reject) => {
cordova.plugin.http.downloadFile(
prootUrl, {}, {},
cordova.file.dataDirectory + "libproot-xed.so",
resolve, reject
);
});
await downloadFile(prootUrl, cordova.file.dataDirectory + "libproot-xed.so", "Compatibility layer");

logger("⬇️ Downloading supporting library...");
await new Promise((resolve, reject) => {
cordova.plugin.http.downloadFile(
libTalloc, {}, {},
cordova.file.dataDirectory + "libtalloc.so.2",
resolve, reject
);
});
await downloadFile(libTalloc, cordova.file.dataDirectory + "libtalloc.so.2", "Supporting library");

if (libproot != null) {
await new Promise((resolve, reject) => {
cordova.plugin.http.downloadFile(
libproot, {}, {},
cordova.file.dataDirectory + "libproot.so",
resolve, reject
);
});
await downloadFile(libproot, cordova.file.dataDirectory + "libproot.so", "proot loader");
}

if (libproot32 != null) {
await new Promise((resolve, reject) => {
cordova.plugin.http.downloadFile(
libproot32, {}, {},
cordova.file.dataDirectory + "libproot32.so",
resolve, reject
);
});
await downloadFile(libproot32, cordova.file.dataDirectory + "libproot32.so", "32-bit proot loader");
}

}
Expand All @@ -218,39 +182,37 @@ const Terminal = {

logger("📁 Setting up directories...");

await new Promise((resolve, reject) => {
system.mkdirs(`${filesDir}/.downloaded`, resolve, reject);
});
await ensureDir(`${filesDir}/.downloaded`);

const alpineDir = `${filesDir}/alpine`;

await new Promise((resolve, reject) => {
system.mkdirs(alpineDir, resolve, reject);
});
await ensureDir(alpineDir);

logger("📦 Extracting sandbox filesystem...");
await Executor.execute(`tar --no-same-owner -xf ${filesDir}/alpine.tar.gz -C ${alpineDir}`);

logger("⚙️ Applying basic configuration...");
system.writeText(`${alpineDir}/etc/resolv.conf`, `nameserver 8.8.4.4 \nnameserver 8.8.8.8`);
await writeText(`${alpineDir}/etc/resolv.conf`, `nameserver 8.8.4.4 \nnameserver 8.8.8.8`);

readAsset("rm-wrapper.sh", async (content) => {
system.deleteFile(`${alpineDir}/bin/rm`, logger, err_logger);
system.writeText(`${alpineDir}/bin/rm`, content, logger, err_logger);
system.setExec(`${alpineDir}/bin/rm`, true, logger, err_logger);
});
const rmWrapper = await readAsset("rm-wrapper.sh");
await deleteFile(`${alpineDir}/bin/rm`).catch(() => {});
await writeText(`${alpineDir}/bin/rm`, rmWrapper);
await setExec(`${alpineDir}/bin/rm`, true);

logger("✅ Extraction complete");
await new Promise((resolve, reject) => {
system.mkdirs(`${filesDir}/.extracted`, resolve, reject);
});
await ensureDir(`${filesDir}/.extracted`);

logger("⚙️ Updating sandbox enviroment...");
const installResult = await this.startAxs(true, logger, err_logger);
if (!installResult) {
throw new Error(this.lastInstallError || "Sandbox configuration failed.");
}
return installResult;

} catch (e) {
err_logger("Installation failed:", e);
const message = formatError(e);
this.lastInstallError = message;
err_logger(`Installation failed: ${message}`);
console.error("Installation failed:", e);
return false;
}
Expand Down Expand Up @@ -439,20 +401,99 @@ const Terminal = {
reject(result);
}
});
}
},

formatError
};


function readAsset(assetPath, callback) {
const assetUrl = "file:///android_asset/" + assetPath;

window.resolveLocalFileSystemURL(assetUrl, fileEntry => {
fileEntry.file(file => {
const reader = new FileReader();
reader.onloadend = () => callback(reader.result);
reader.readAsText(file);
}, console.error);
}, console.error);
const promise = new Promise((resolve, reject) => {
window.resolveLocalFileSystemURL(assetUrl, fileEntry => {
fileEntry.file(file => {
const reader = new FileReader();
reader.onloadend = () => resolve(reader.result);
reader.onerror = () => reject(reader.error || new Error(`Failed to read ${assetPath}`));
reader.readAsText(file);
}, reject);
}, reject);
});

if (callback) {
promise.then(callback).catch(console.error);
}

return promise;
}

function fileExists(path) {
return new Promise((resolve, reject) => {
system.fileExists(path, false, (result) => {
resolve(result == 1);
}, reject);
});
}

async function ensureDir(path) {
if (await fileExists(path)) return;

await new Promise((resolve, reject) => {
system.mkdirs(path, resolve, reject);
});
}

function writeText(path, content) {
return new Promise((resolve, reject) => {
system.writeText(path, content, resolve, reject);
});
}

function deleteFile(path) {
return new Promise((resolve, reject) => {
system.deleteFile(path, resolve, reject);
});
}

function setExec(path, executable) {
return new Promise((resolve, reject) => {
system.setExec(path, executable, resolve, reject);
});
}

function downloadFile(url, destination, label) {
return new Promise((resolve, reject) => {
cordova.plugin.http.downloadFile(
url, {}, {},
destination,
resolve,
(error) => reject(new Error(`${label} download failed: ${formatError(error)}`))
);
});
}

function formatError(error) {
if (error == null) return "Unknown error";
if (error instanceof Error) return error.message || String(error);
if (typeof error === "string") return error || "Unknown error";
if (typeof error === "object") {
const parts = [];
if (error.status != null) parts.push(`status ${error.status}`);
if (error.error) parts.push(String(error.error));
if (error.message) parts.push(String(error.message));
if (error.exception) parts.push(String(error.exception));
if (error.url) parts.push(`URL: ${error.url}`);
if (parts.length) return parts.join(" - ");

try {
return JSON.stringify(error);
} catch (jsonError) {
return String(error);
}
}

return String(error);
}

module.exports = Terminal;
module.exports = Terminal;