From 73b31859c44405c00b757096cb4a9cff84e3cef9 Mon Sep 17 00:00:00 2001 From: Renegade334 Date: Thu, 16 Apr 2026 20:35:41 +0200 Subject: [PATCH] src: use context-free V8 message column getters --- src/inspector_agent.cc | 2 +- src/node_errors.cc | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc index 068da4c01bc1c9..5e1d9149dc755a 100644 --- a/src/inspector_agent.cc +++ b/src/inspector_agent.cc @@ -677,7 +677,7 @@ class NodeInspectorClient : public V8InspectorClient { ToInspectorString(isolate, message->Get())->string(), ToInspectorString(isolate, message->GetScriptResourceName())->string(), message->GetLineNumber(context).FromMaybe(0), - message->GetStartColumn(context).FromMaybe(0), + message->GetStartColumn(), client_->createStackTrace(stack_trace), script_id); } diff --git a/src/node_errors.cc b/src/node_errors.cc index 23ca0bc50f68c6..a2ece94b938c21 100644 --- a/src/node_errors.cc +++ b/src/node_errors.cc @@ -65,7 +65,7 @@ static std::string GetSourceMapErrorSource(Isolate* isolate, // the source texts. Local script_resource_name = message->GetScriptResourceName(); int linenum = message->GetLineNumber(context).FromJust(); - int columnum = message->GetStartColumn(context).FromJust(); + int columnum = message->GetStartColumn(); Local argv[] = {script_resource_name, v8::Int32::New(isolate, linenum), @@ -148,8 +148,8 @@ static std::string GetErrorSource(Isolate* isolate, int script_start = (linenum - origin.LineOffset()) == 1 ? origin.ColumnOffset() : 0; - int start = message->GetStartColumn(context).FromMaybe(0); - int end = message->GetEndColumn(context).FromMaybe(0); + int start = message->GetStartColumn(); + int end = message->GetEndColumn(); if (start >= script_start) { CHECK_GE(end, start); start -= script_start;